Merge "US Subscriptions" into dev #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
zan-US1297-subscriptions
branch
2 times, most recently
from
befefc4
to
735a088
Compare
When you expand a transaction to display detail, we try to display informations about a document and an item. These metadata are only sense for a 'overdue' transaction. This commit check the patron transaction type to display information depending of it. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
New fields are added to patron_types resource in the backend. Updates the detail view to reflect these changes. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Fixes a missing comma in circulation module. Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-US1297-subscriptions
branch
from
ca375d9
to
80677be
Compare
* Fixes translations about subscription user story * Fixes path typo Co-authored-by : Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you opening this PR?
Merge "US subscription" into dev
Code review check list