Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

holdings: add patterns support #251

Merged
merged 1 commit into from
Apr 23, 2020
Merged

holdings: add patterns support #251

merged 1 commit into from
Apr 23, 2020

Conversation

jma
Copy link
Contributor

@jma jma commented Apr 23, 2020

  • Adds a new holding editor to support patterns (prediction) preview.
  • Suppport tree types of holdings in the professionnal document detailed
    view.
    • standard: the add/edit button load the item editor.
    • electronic: no action is available. It replaces the use of the
      harvested property.
    • serial: the add/edit button load the holding editor.
  • Makes the button in the document detailed view compliant with the last
    UI specifications.
    • Removes textes in the list.
    • Uses outline buttons.
    • Changes the color.
    • Replaces the dialog displayed when a ressource cannot be deleted by
      a popover.
  • Code refactoring:
    • Adds code documentations.
    • Renames functions.
    • Moves the responsability to delete an element to the list components (i.e. holdings
      instead of holding).
    • Puts the ng-templates at the end of template files.
    • Adds _ prefix to the private properties.
    • Uses the new permissions route guards.
    • Renames Base-route.ts file to base-route.ts.

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

* Adds a new holding editor to support patterns (prediction) preview.
* Suppport tree types of holdings in the professionnal document detailed
view.
  * standard: the add/edit button load the item editor.
  * electronic: no action is available. It replaces the use of the
  harvested property.
  * serial: the add/edit button load the holding editor.
* Makes the button in the document detailed view compliant with the last
UI specifications.
  * Removes textes in the list.
  * Uses outline buttons.
  * Changes the color.
  * Replaces the dialog displayed when a ressource cannot be deleted by
  a popover.
* Code refactoring:
  * Adds code documentations.
  * Renames functions.
  * Moves the responsability to delete an element to the list components (i.e. holdings
  instead of holding).
  * Puts the ng-templates at the end of template files.
  * Adds _ prefix to the private properties.
  * Uses the new permissions route guards.
  * Renames Base-route.ts file to base-route.ts.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma merged commit e5aa8c9 into dev Apr 23, 2020
@jma jma deleted the US1039-pub-patterns branch April 28, 2020 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant