autocomplete: fix suggestions list #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jma
force-pushed
the
maj-ngx-bootstrap-3.6
branch
2 times, most recently
from
df2e079
to
01b5b31
Compare
jma
changed the title
7 tasks
jma
force-pushed
the
maj-ngx-bootstrap-3.6
branch
4 times, most recently
from
359ac08
to
770e164
Compare
jma
changed the title
jma
force-pushed
the
maj-ngx-bootstrap-3.6
branch
from
770e164
to
0758970
Compare
Old version of the third party library `ngx-bootstrap` had sometime weird behaviors. `@rero/ng-core@0.2.3` fix this. * Fixes `ngx-bootstrap` imports to be angular 9 and `ngx-bootstrap>6` compliant. * Fixes tests form other pull requests by mocking the services. * Updates dependency @rero/ng-core to version 0.2.3. * Fixes the number of suggestions for each category documents and direct links to be sure that all suggestions are displayed. Note: several versions of `ngx-bootstrap` has been tried, but some of them failed: - 3.3.x: does not display a `typeahead` suggestion list for slow query. - 3.6.1: does not compile our project in production. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma
force-pushed
the
maj-ngx-bootstrap-3.6
branch
from
0758970
to
2fd3bb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old version of the third party library
ngx-bootstraphad sometime weirdbehaviors.
@rero/ng-core@0.2.3fix this.ngx-bootstrapimports to be angular 9 andngx-bootstrap>6compliant.
links to be sure that all suggestions are displayed.
Note: several versions of
ngx-bootstraphas been tried, but some ofthem failed:
typeaheadsuggestion list for slow query.Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Dependencies
Why are you opening this PR?
How to test?
Code review check list