Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor: link persons to source instead of MEF #269

Merged
merged 1 commit into from
May 19, 2020
Merged

editor: link persons to source instead of MEF #269

merged 1 commit into from
May 19, 2020

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented May 13, 2020

  • Links documents to the source authority file, such as GND or IdRef,
    through the MEF server, instead of the MEF clusterized record. This
    is needed to provide a stable link to the authority.

My PR depends on the following rero-ils's PR(s):

Co-Authored-by: Peter Weber peter.weber@rero.ch

Why are you opening this PR?

How to test?

  • Try to edit an document and add an person

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@rerowep rerowep self-assigned this May 13, 2020
@rerowep rerowep requested a review from AoNoOokami May 13, 2020 13:08
@rerowep rerowep force-pushed the wep-#1464-idref-gnd-persons-link branch 2 times, most recently from a1fdf2c to da271e7 Compare May 13, 2020 14:15
rerowep added a commit to rerowep/rero-ils that referenced this pull request May 14, 2020
@rerowep
persons: link persons to source instead of MEF
2fbb8c3 
* Links documents to the source authority file, such as GND or IdRef,
  through the MEF server, instead of the MEF clusterized record. This
  is needed to provide a stable link to the authority.

My PR depends on the following `rero-ils`'s PR(s):

* rero/rero-ils-ui#269

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
iGormilhit
iGormilhit suggested changes May 15, 2020
View reviewed changes
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove PR dependency mention in the commit and also unnecessary blank line and the 'r' at the end.

@rerowep rerowep force-pushed the wep-#1464-idref-gnd-persons-link branch from da271e7 to 015a21b Compare May 15, 2020 06:43
@benerken
Copy link
Contributor

benerken commented May 15, 2020 •
edited
Loading

Tested locally (rero-ils PR972 + rero-ils-ui PR269)

I have created a new document (import EAN 9782035930910)
I have linked the author to a MEF entry

image

I have saved the new record
In the JSON, I can see the link to MEF/IDRef

image

But in the document view, the author name is NOT displayed in the professional view
(it's displayed in the public view)

image

benerken
benerken requested changes May 15, 2020
View reviewed changes
Copy link
Contributor

@benerken benerken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with rero-ils PR972 + rero-ils-ui PR269, the authors are not displayed anymore in the professional view.
Could you fix that please ?
(There is no problem in the public view).

rerowep added a commit to rerowep/rero-ils that referenced this pull request May 16, 2020
@rerowep
persons: link persons to source instead of MEF
62b2f54 
* Links documents to the source authority file, such as GND or IdRef,
  through the MEF server, instead of the MEF clusterized record. This
  is needed to provide a stable link to the authority.

My PR depends on the following `rero-ils`'s PR(s):

* rero/rero-ils-ui#269

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rerowep/rero-ils that referenced this pull request May 16, 2020
@rerowep
persons: link persons to source instead of MEF
6f87701 
* Links documents to the source authority file, such as GND or IdRef,
  through the MEF server, instead of the MEF clusterized record. This
  is needed to provide a stable link to the authority.

My PR depends on the following `rero-ils`'s PR(s):

* rero/rero-ils-ui#269

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rerowep/rero-ils that referenced this pull request May 16, 2020
@rerowep
persons: link persons to source instead of MEF
0ce3eee 
* Links documents to the source authority file, such as GND or IdRef,
  through the MEF server, instead of the MEF clusterized record. This
  is needed to provide a stable link to the authority.

My PR depends on the following `rero-ils`'s PR(s):

* rero/rero-ils-ui#269

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rerowep/rero-ils that referenced this pull request May 16, 2020
@rerowep
persons: link persons to source instead of MEF
77745da 
* Links documents to the source authority file, such as GND or IdRef,
  through the MEF server, instead of the MEF clusterized record. This
  is needed to provide a stable link to the authority.

My PR depends on the following `rero-ils`'s PR(s):

* rero/rero-ils-ui#269

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rerowep/rero-ils that referenced this pull request May 17, 2020
@rerowep
persons: link persons to source instead of MEF
dd7aa7f 
* Links documents to the source authority file, such as GND or IdRef,
  through the MEF server, instead of the MEF clusterized record. This
  is needed to provide a stable link to the authority.

My PR depends on the following `rero-ils`'s PR(s):

* rero/rero-ils-ui#269

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@iGormilhit iGormilhit self-requested a review May 18, 2020 04:55
@iGormilhit
Copy link
Contributor

with rero-ils PR972 + rero-ils-ui PR269, the authors are not displayed anymore in the professional view.
Could you fix that please ?
(There is no problem in the public view).

@rerowep I can confirm this.

jma
jma requested changes May 18, 2020
View reviewed changes
projects/admin/src/app/record/editor/remote-autocomplete/remote-autocomplete.component.ts Outdated Show resolved Hide resolved
projects/admin/src/app/record/editor/remote-autocomplete/remote-autocomplete.component.ts Outdated
});
return names;
})
);
}

getNameRef(metadata, source, query) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing documentation

projects/admin/src/app/record/editor/remote-autocomplete/remote-autocomplete.component.ts Outdated
};
}

getNameSource(source) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing documentation

@rerowep rerowep force-pushed the wep-#1464-idref-gnd-persons-link branch from 015a21b to 24c6f19 Compare May 18, 2020 11:49
rerowep added a commit to rerowep/rero-ils that referenced this pull request May 18, 2020
@rerowep
persons: link persons to source instead of MEF
6115b0f 
* Links documents to the source authority file, such as GND or IdRef,
  through the MEF server, instead of the MEF clusterized record. This
  is needed to provide a stable link to the authority.

My PR depends on the following `rero-ils`'s PR(s):

* rero/rero-ils-ui#269

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@rerowep
Copy link
Contributor Author

rerowep commented May 18, 2020

with rero-ils PR972 + rero-ils-ui PR269, the authors are not displayed anymore in the professional view.
Could you fix that please ?
(There is no problem in the public view).

Fixed

@rerowep rerowep requested a review from benerken May 18, 2020 11:50
@rerowep rerowep force-pushed the wep-#1464-idref-gnd-persons-link branch from 24c6f19 to 7cca52e Compare May 18, 2020 13:33
@rerowep
editor: link persons to source instead of MEF
932e24b 
* Links documents to the source authority file, such as GND or IdRef,
  through the MEF server, instead of the MEF clusterized record. This
  is needed to provide a stable link to the authority.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@rerowep rerowep force-pushed the wep-#1464-idref-gnd-persons-link branch from 7cca52e to 932e24b Compare May 18, 2020 15:28
rerowep added a commit to rerowep/rero-ils that referenced this pull request May 18, 2020
@rerowep
persons: link persons to source instead of MEF
6097362 
* Links documents to the source authority file, such as GND or IdRef,
  through the MEF server, instead of the MEF clusterized record. This
  is needed to provide a stable link to the authority.

My PR depends on the following `rero-ils`'s PR(s):

* rero/rero-ils-ui#269

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rerowep/rero-ils that referenced this pull request May 18, 2020
@rerowep
persons: link persons to source instead of MEF
e9d8d52 
* Links documents to the source authority file, such as GND or IdRef,
  through the MEF server, instead of the MEF clusterized record. This
  is needed to provide a stable link to the authority.

My PR depends on the following `rero-ils`'s PR(s):

* rero/rero-ils-ui#269

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rero/rero-ils that referenced this pull request May 19, 2020
@rerowep
persons: link persons to source instead of MEF
7495228 
* Links documents to the source authority file, such as GND or IdRef,
  through the MEF server, instead of the MEF clusterized record. This
  is needed to provide a stable link to the authority.

My PR depends on the following `rero-ils`'s PR(s):

* rero/rero-ils-ui#269

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@rerowep rerowep mentioned this pull request May 19, 2020
Merged
7 tasks
rerowep added a commit to rero/rero-ils that referenced this pull request May 19, 2020
@rerowep
persons: link persons to source instead of MEF
aa81fc9 
* Links documents to the source authority file, such as GND or IdRef,
  through the MEF server, instead of the MEF clusterized record. This
  is needed to provide a stable link to the authority.

My PR depends on the following `rero-ils`'s PR(s):

* rero/rero-ils-ui#269

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rero/rero-ils that referenced this pull request May 19, 2020
@rerowep
persons: link persons to source instead of MEF
2f4ebd8 
* Links documents to the source authority file, such as GND or IdRef,
  through the MEF server, instead of the MEF clusterized record. This
  is needed to provide a stable link to the authority.

My PR depends on the following `rero-ils`'s PR(s):

* rero/rero-ils-ui#269

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@rerowep rerowep merged commit 02d2fc1 into rero:dev May 19, 2020
@rerowep rerowep deleted the wep-#1464-idref-gnd-persons-link branch December 17, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AoNoOokami AoNoOokami Awaiting requested review from AoNoOokami

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

@iGormilhit iGormilhit Awaiting requested review from iGormilhit

@benerken benerken Awaiting requested review from benerken

@jma jma Awaiting requested review from jma

Assignees

@rerowep rerowep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rerowep @benerken @iGormilhit @jma