Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

menu: make the language menu more consistent #277

Merged
merged 1 commit into from
Jun 8, 2020
Merged

menu: make the language menu more consistent #277

merged 1 commit into from
Jun 8, 2020

Conversation

jma
Copy link
Contributor

@jma jma commented Jun 3, 2020 •
edited
Loading

  • Changes the menu language to be close to the public interface.
    • Uses the same icons.
    • Removes the current language.
    • Avoids language text translations.
    • Adds a divider.
  • Upgrades ngx-formly and ngx-translate-extract to user the same version
    as ng-core.
  • Removes useless variables and uses the ngx-translate current language
    in the language menu.

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Why are you opening this PR?

Dependencies

My PR depends on ng-core's PR(s): rero/ng-core#187

How to test?

  • Start the admin application and that the language menu correspond to the public interface.

Screenshot

image

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@jma jma force-pushed the maj-editor-translations branch from c70eb17 to dadbd98 Compare June 4, 2020 07:22
@jma jma changed the title translations: editor menu: make the language menu more consistent Jun 4, 2020
@jma jma marked this pull request as ready for review June 4, 2020 07:30
@jma jma force-pushed the maj-editor-translations branch from dadbd98 to 6bfd57e Compare June 4, 2020 07:32
@jma jma requested a review from Garfield-fr June 4, 2020 07:32
@jma jma mentioned this pull request Jun 4, 2020
Merged
7 tasks
@jma jma force-pushed the maj-editor-translations branch from 6bfd57e to 6e90817 Compare June 4, 2020 13:37
@jma jma requested review from zannkukai and iGormilhit June 4, 2020 13:41
@jma jma force-pushed the maj-editor-translations branch from 6e90817 to f1ad307 Compare June 5, 2020 05:19
iGormilhit
iGormilhit reviewed Jun 8, 2020
View reviewed changes
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message: Changes the menu language to be close to the public interface. → Make the language menu looks like the public interface menu or something approching.

@jma @chezjohnny
menu: make the language menu more consistent
448c2ef 
* Make the language menu looks like the public interface menu.
  * Uses the same icons.
  * Removes the current language.
  * Avoids language text translations.
  * Adds a divider.
* Upgrades ngx-formly and ngx-translate-extract to user the same version
  as ng-core.
* Removes useless variables and uses the ngx-translate current language
  in the language menu.
* Removes debug messages (console.log).
* Closes rero/rero-ils#943.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma force-pushed the maj-editor-translations branch from f1ad307 to 448c2ef Compare June 8, 2020 06:35
@jma jma merged commit cdf7efa into rero:dev Jun 8, 2020
@jma jma deleted the maj-editor-translations branch July 14, 2020 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit left review comments

@zannkukai zannkukai zannkukai approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jma @Garfield-fr @iGormilhit @zannkukai