items: display items notes #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benerken
approved these changes
Jun 5, 2020
lauren-d
approved these changes
Jun 5, 2020
iGormilhit
approved these changes
Jun 8, 2020
Garfield-fr
approved these changes
Jun 8, 2020
zannkukai
force-pushed
the
zan-#items-notes-display
branch
from
f8a703e
to
f619675
Compare
AoNoOokami
reviewed
Jun 8, 2020
projects/admin/src/app/record/detail-view/item-detail-view/item-detail-view.component.html
Outdated
Show resolved
Hide resolved
zannkukai
force-pushed
the
zan-#items-notes-display
branch
5 times, most recently
from
ad26717
to
266074d
Compare
zannkukai
force-pushed
the
zan-#items-notes-display
branch
from
266074d
to
85bbbff
Compare
Adapts the item detail view to display notes related to an item. Adds manual translations for note type. Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-#items-notes-display
branch
from
85bbbff
to
6ae39f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts the item detail view to display notes related to an item.
Co-authored-by: Renaud Michotte renaud.michotte@gmail.com
Why are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/us/1352?milestone=266303
How to test?
use rero/rero-ils#1026 (backend) bootstrap + setup
Code review check list