-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
circulation: display circulation notes automatically. #280
circulation: display circulation notes automatically. #280
Conversation
371d9a7
to
ce0e73c
Compare
ce0e73c
to
b43b055
Compare
b43b055
to
a5ea4ce
Compare
a5ea4ce
to
8ed0dcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments
-
Should we have an upper case on "Exemplaire" in the checkin and checkout note?
Actually I would simplify, remove this text and the item barcode, and display only the note content. -
If there is a checkin/checkout note, I would add a small icon next to the barcode in the loan line. It is easier to find the relation than to compare barcodes. @iGormilhit This was your proposal during last discussion, right?
@pronguen Yes, as I remember, I proposed this also for the document detailed view (item barcode in the holdings). But, that was to identify item with note. To make the link between the toast message and the item, I don't know if it enough. The barcode is indeed not so easy to remember quickly (I would not, most of the time, but I'm old, you know 😉 ). |
I would let the barcode. If we check-in several items and don't see immediately the note, it's easier to find back the good item with it, no ? |
When circulation operations are done, if item contains the corresponding circulation note, this note will be displayed as a permanent toastr message. * refactoring item circulation collapsed informations design. * adds postprocessRecord behavior to avoid empty notes array on item. Co-authored-by : Renaud Michotte <renaud.michotte@gmail.com>
8ed0dcd
to
557ac5d
Compare
@JoelleDosimont It seems we found a good solution with a "callout" wrapper adding a warning border around the item with a note + sticky icon. |
When circulation operations are done, if item contains the corresponding
circulation note, this note will be displayed as a permanent toastr
message.
Co-authored-by : Renaud Michotte renaud.michotte@gmail.com
Why are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/us/1352?milestone=266303
Dependencies
(backend) rero/rero-ils#1026
How to test?
Code review check list