Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document: adapt display of field "notes" #288

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

AoNoOokami
Copy link
Contributor

@AoNoOokami AoNoOokami commented Jun 22, 2020

  • Creates a pipe to display the field "notes".
  • Corrects detail view accordingly.

Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch

Why are you opening this PR?

To adapt the UI for the correction of the edition of a document with notes.

Dependencies

My PR depends on rero-ils#<xx>'s PR(s):

How to test?

Check the detail view of documents with notes.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@AoNoOokami AoNoOokami marked this pull request as ready for review June 22, 2020 13:16
@AoNoOokami AoNoOokami force-pushed the zaa-fix-notes-display branch 2 times, most recently from aebdbf6 to bc720d6 Compare June 22, 2020 13:35
* Creates a pipe to display the field "notes".
* Corrects detail view accordingly.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami force-pushed the zaa-fix-notes-display branch from bc720d6 to 3bd21f1 Compare June 22, 2020 13:45
@AoNoOokami AoNoOokami requested review from zannkukai and jma June 22, 2020 13:56
@AoNoOokami AoNoOokami added this to the v0.10.0 (rero-ils) milestone Jun 22, 2020
@AoNoOokami AoNoOokami self-assigned this Jun 22, 2020
@AoNoOokami AoNoOokami merged commit 5e42130 into rero:dev Jun 23, 2020
@AoNoOokami AoNoOokami deleted the zaa-fix-notes-display branch July 21, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants