project: downgrade ngx-spinner version #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauren-d
requested review from
AoNoOokami,
blankoworld,
Garfield-fr,
jma,
sebdeleze and
zannkukai
zannkukai
approved these changes
Jul 20, 2020
lauren-d
force-pushed
the
lau-downgrade-ngx-spinner
branch
3 times, most recently
from
eff7853
to
29cddb1
Compare
Garfield-fr
approved these changes
Jul 21, 2020
iGormilhit
suggested changes
Jul 21, 2020
There was a problem hiding this comment.
Commit message proposition:
project: downgrade ngx-spinner version
* Downgrades the ngx-spinner version for compatibility with Angular 8.
* Updates two HTML templates to use spinner on ng-core components
because the migration to ngx-spinner removed the old spinner.
jma
force-pushed
the
lau-downgrade-ngx-spinner
branch
2 times, most recently
from
c1c1075
to
cf3d0fd
Compare
iGormilhit
approved these changes
Jul 21, 2020
AoNoOokami
approved these changes
Jul 21, 2020
lauren-d
force-pushed
the
lau-downgrade-ngx-spinner
branch
from
cf3d0fd
to
8d3de54
Compare
7 tasks
jma
force-pushed
the
lau-downgrade-ngx-spinner
branch
from
8d3de54
to
05442d2
Compare
* Downgrades the ngx-spinner version for compatibility with Angular 8. * Updates two HTML templates to use spinner on ng-core components because the migration to ngx-spinner removed the old spinner. * Uses ng-core v0.6.0. Co-Authored-by: Lauren-D <laurent.dubois@itld-solutions.be>
jma
force-pushed
the
lau-downgrade-ngx-spinner
branch
from
05442d2
to
75640ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because the migration to ngx-spinner removed the old spinner.
Co-Authored-by: Lauren-D laurent.dubois@itld-solutions.be
Why are you opening this PR?
Dependencies
My PR depends on
rero-ils#<xx>'s PR(s):How to test?
Code review check list