document editor: fix bnf import #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebdeleze
suggested changes
Jul 23, 2020
Comment on lines
18
to
19
| import { Component } from '@angular/core'; | ||
| import { ToastrService } from 'ngx-toastr'; | ||
| import { TranslateService } from '@ngx-translate/core'; | ||
| import { EditorService } from '../../../service/editor.service'; | ||
| import { ActivatedRoute } from '@angular/router'; |
| * | ||
| * @param value - true if the child editor component is currently loading data | ||
| */ | ||
| loadingChanged(value) { |
* Changes the sequence of editor initalization to avoid concurency problem with the JSONSchema loading. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem with the JSONSchema loading.
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Why are you opening this PR?
Dependencies
My PR depends on the following PR(s):
How to test?
Code review check list