circulation : toastr message when item goes in transit #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
zan-toastr-message-for-transit
branch
from
f83f278
to
b5d23c8
Compare
zannkukai
force-pushed
the
zan-toastr-message-for-transit
branch
2 times, most recently
from
7d3eca2
to
118c208
Compare
zannkukai
changed the title
AoNoOokami
approved these changes
Aug 17, 2020
iGormilhit
suggested changes
Aug 18, 2020
There was a problem hiding this comment.
Commit message: from When an item is checked-in and goes in transit, add a toastr message to informs user about this spec. to Adds a toastr message to inform the librarian that the checked-in item goes in transit. Or something else, but this spec is a bit strange, at least for me.
iGormilhit
added
the
f: circulation
zannkukai
force-pushed
the
zan-toastr-message-for-transit
branch
2 times, most recently
from
4b99a16
to
f0170c7
Compare
iGormilhit
approved these changes
Aug 19, 2020
zannkukai
force-pushed
the
zan-toastr-message-for-transit
branch
3 times, most recently
from
b665838
to
f19d8b3
Compare
zannkukai
force-pushed
the
zan-toastr-message-for-transit
branch
from
f19d8b3
to
cb38fcc
Compare
sebdeleze
suggested changes
Aug 24, 2020
projects/admin/src/app/circulation/checkin/checkin.component.ts
Outdated
Show resolved
Hide resolved
zannkukai
force-pushed
the
zan-toastr-message-for-transit
branch
from
cb38fcc
to
5a64f15
Compare
Adds a toastr message to inform the librarian that the checked-in item goes in transit with destination informations into. Co-Authored-by: Renaud Michtote <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-toastr-message-for-transit
branch
from
5a64f15
to
a653853
Compare
sebdeleze
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an item is checked-in and goes in transit, add a toastr message to
informs user about this spec.
Co-Authored-by: Renaud Michote renaud.michotte@gmail.com
How to test?
Code review check list