circulation: allow request for organisation items #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
zan-#1656-fix-request-permissions
branch
2 times, most recently
from
f67bcad
to
fbde8eb
Compare
zannkukai
commented
Aug 20, 2020
| @@ -30,23 +30,21 @@ | |||
| {{ callNumber }} | |||
| </div> | |||
| <div class="col-sm-4 text-right"> | |||
| <ng-container *ngIf="isHoldingMatchUserLibraryPID"> | |||
There was a problem hiding this comment.
diff is not always user friendly... in this case I only removed <ng-container *ngIf="isHoldingMatchUserLibraryPID">. The button is now based only on permissions.
iGormilhit
added
the
f: circulation
zannkukai
force-pushed
the
zan-#1656-fix-request-permissions
branch
2 times, most recently
from
fd19de8
to
a4c9304
Compare
iGormilhit
reviewed
Aug 25, 2020
zannkukai
force-pushed
the
zan-#1656-fix-request-permissions
branch
from
a4c9304
to
19447f4
Compare
AoNoOokami
approved these changes
Aug 25, 2020
sebdeleze
approved these changes
Aug 25, 2020
iGormilhit
approved these changes
Aug 26, 2020
The request document button was only available for the current library items. This commit updates this behavior; now all items of the current logged user application can be requested. Closes rero/rero-ils#927 Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-#1656-fix-request-permissions
branch
from
19447f4
to
c74dc0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request document button was only available for the current library
items. This commit updates this behavior ; now all items of the current
logged user application can be requested.
Co-authored-by: Renaud Michotte renaud.michotte@gmail.com
Why are you opening this PR?
Closes rero/rero-ils#927
How to test?
Code review check list