circulation: fix patron info in loan view #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
force-pushed
the
zaa-#1693-fix-patron-info
branch
from
a944470
to
98325b7
Compare
zannkukai
approved these changes
Aug 24, 2020
AoNoOokami
force-pushed
the
zaa-#1693-fix-patron-info
branch
from
98325b7
to
1dc78ca
Compare
iGormilhit
added
f: circulation
iGormilhit
reviewed
Aug 25, 2020
AoNoOokami
force-pushed
the
zaa-#1693-fix-patron-info
branch
from
1dc78ca
to
9245aa2
Compare
AoNoOokami
requested review from
zannkukai and
sebdeleze
and removed request for
benerken
zannkukai
approved these changes
Aug 25, 2020
sebdeleze
suggested changes
Aug 25, 2020
projects/admin/src/app/circulation/checkin/checkin.component.ts
Outdated
Show resolved
Hide resolved
AoNoOokami
force-pushed
the
zaa-#1693-fix-patron-info
branch
from
9245aa2
to
db81980
Compare
sebdeleze
approved these changes
Aug 25, 2020
* Fixes patron info in loan view: it couldn't be removed in order to go to checkin view (displayPatronMode is setted to false in checkin view and not updated when going to loan view). * Fixes the display of a flash error message saying 'patron is undefined' when going to loan view after a checkin in checkin view. Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami
force-pushed
the
zaa-#1693-fix-patron-info
branch
from
db81980
to
2d9eab4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to checkin view (displayPatronMode is setted to false in checkin view
and not updated when going to loan view).
undefined' when going to loan view after a checkin in checkin view.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Why are you opening this PR?
Task 1693 of US1665
Dependencies
N/A
How to test?
Do a checkin or a receive in checkin view (User services > Circulation).
Then type a patron barcode to go to patron loan view. A red button should be displayed in order to remove patron info and go back to checkin view.
No error flash message saying
patron is undefinedshould be displayed.Code review check list