editor: define custom documents typeahead type #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauren-d
force-pushed
the
lau-custom-documents-typeahead
branch
3 times, most recently
from
677105e
to
9c56780
Compare
lauren-d
requested review from
Garfield-fr,
zannkukai,
jma,
AoNoOokami and
iGormilhit
lauren-d
force-pushed
the
lau-custom-documents-typeahead
branch
from
9c56780
to
72a9760
Compare
6 tasks
lauren-d
force-pushed
the
lau-custom-documents-typeahead
branch
from
72a9760
to
f21ce2e
Compare
zannkukai
approved these changes
Aug 28, 2020
lauren-d
force-pushed
the
lau-custom-documents-typeahead
branch
2 times, most recently
from
76d9147
to
a71955a
Compare
iGormilhit
reviewed
Aug 31, 2020
Extends remote typeahead component to be able to search list of suggestion of documents. * Adds a new class for custom documents typeahead. Co-Authored-by: Lauren-D <laurent.dubois@itld-solutions.be> Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
lauren-d
force-pushed
the
lau-custom-documents-typeahead
branch
from
a71955a
to
eba11fe
Compare
AoNoOokami
approved these changes
Aug 31, 2020
iGormilhit
approved these changes
Sep 1, 2020
jma
approved these changes
Sep 1, 2020
benerken
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends remote typeahead component to be able to search list
of suggestion of documents.
Co-Authored-by: Lauren-D laurent.dubois@itld-solutions.be
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
Why are you opening this PR?
Dependencies
My PR depends on
rero-ils#<xx>'s PR(s):How to test?
Code review check list