app: standardize initialization #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
requested review from
jma,
AoNoOokami,
zannkukai,
lauren-d and
sebdeleze
zannkukai
approved these changes
Sep 29, 2020
Initializes the application according to angular standards. * Adds a service for initialization. * Adds a service for router initialization. * Improves app component template. * Improves tests. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr
force-pushed
the
zub-app-initializer
branch
from
4812f48
to
b9f19dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializes the application according to angular standards.
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
Code review check list