Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: update PR template #387

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Conversation

AoNoOokami
Copy link
Contributor

  • Removes translations form the checklist, as they are managed in a specific branch now.

Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch

Why are you opening this PR?

To update PR template according to new translation workflow.

Dependencies

My PR depends on rero-ils#<xx>'s PR(s):

N/A

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

* Removes translations form the checklist, as they are managed in a specific branch now.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami requested review from zannkukai and removed request for sebdeleze October 14, 2020 15:13
@AoNoOokami AoNoOokami merged commit f5a95df into rero:dev Oct 20, 2020
@AoNoOokami AoNoOokami deleted the zaa-update-PR-template branch November 6, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants