Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactors user resource #389

Merged
merged 2 commits into from
Oct 14, 2020
Merged

refactors user resource #389

merged 2 commits into from
Oct 14, 2020

Conversation

jma
Copy link
Contributor

@jma jma commented Oct 13, 2020

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on rero-ils#<xx>'s PR(s):

  • rero/rero-ils#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

Alicia Zangger and others added 2 commits October 13, 2020 16:45
@jma
patron: rename as user
8874a03 
* Replaces 'patron' with 'user' in menu and users list.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@jma
patron: add new fields
17087f3 
* Adds expiration date.
* Adds affiliation libraries.
* Adds username.
* Adds user notes.
* Moves the patron information in a common patron properties.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma force-pushed the maj-US1590-user-resource branch from e1a48cc to 17087f3 Compare October 13, 2020 14:46
@jma jma marked this pull request as ready for review October 13, 2020 14:46
@jma jma merged commit a2fa1ae into dev Oct 14, 2020
@jma jma deleted the maj-US1590-user-resource branch October 14, 2020 08:12
@iGormilhit iGormilhit changed the title Maj us1590 user resource refactors user resource Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jma