Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patron: improve performance of the patron account display #395

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

zannkukai
Copy link
Contributor

@zannkukai zannkukai commented Oct 19, 2020

At this time, the patron account (checkin-checkout) is displayed only
when all data has been resolved from backend ; with many linked loans
this will take a long time (more than 20 seconds before displaying
something).
This PR solves this problem : a first call is requested to get linked
item pids/barcode. Next for each barcode, we request the detail about
this item.

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Why are you opening this PR?

ICC problem with #383 ... reopen this PR to merge

Dependencies

My PR depends on rero-ils#<xx>'s PR(s):

  • rero/rero-ils#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

At this time, the patron account (checkin-checkout) is displayed only
when all data has been resolved from backend ; with many linked loans
this will take a long time (more than 20 seconds before displaying
something).
This PR solves this problem : a first call is requested to get linked
item pids/barcode. Next for each barcode, we request the detail about
this item.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@zannkukai zannkukai self-assigned this Oct 19, 2020
@jma jma merged commit 3ab71d3 into rero:dev Oct 19, 2020
@zannkukai zannkukai deleted the zan-fix-1246-pro-interface branch October 19, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants