Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contribution: implements organisation agents #398

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Oct 21, 2020

The shared folder allows you to share code between several projects.
The project tests have been adapted with the new structure of the Shared module.
Displays organisation agent data in the document brief and detailed view.
Allows the librarian to search for organisation agent authority record in the MEF server when cataloguing.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Depedencies

Why are you opening this PR?

  • Contributions: Person and Organisation

How to test?

  • Check views person or organisation on public and admin.
  • Check Typeahead on document for person and organisation.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@Garfield-fr Garfield-fr force-pushed the zub-#1750-contribution branch 6 times, most recently from b0dec88 to 14e0e3a Compare October 21, 2020 11:15
@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Oct 21, 2020

  • In the public interface, I get an internal server error when I click to the document linked to the contribution. Ex: American Institute of Physics.

  • The text 'contribution' is not well displayed. See below. --> Maybe this icon shouldn't be displayed at all in the detail view, as in the professional interface?
    image

  • I get more results in the pro interface than the public interface. Ex: search for 'museum' : in the professional interface I get 6 results, in the public interface only one (login as librarian or system lib).

@Garfield-fr Garfield-fr force-pushed the zub-#1750-contribution branch from 14e0e3a to a22848e Compare October 22, 2020 05:20
@benerken
Copy link
Contributor

benerken commented Oct 22, 2020

  • On ilsdev, some organisation contributors are indexed, appear in a result set but don't appear in the autocomplete search

Try to look for "Université catholique de Louvain", it doesn't work
(Ex: https://ilsdev.test.rero.ch/global/contributions/2510629)
image

Try to look for "AIP", it works
(https://ilsdev.test.rero.ch/global/contributions/4041443)
image

@Garfield-fr Garfield-fr force-pushed the zub-#1750-contribution branch 4 times, most recently from c1cc0bd to 58d08fc Compare October 22, 2020 06:16
@pronguen
Copy link
Contributor

  • The facet "Author" is missing (pro + public interface)
  • The variant names of persons and organisations are not indexed in the documents (pro + public interface)
  • In the menu "Catalog > Corporate Bodies", bodies should be lower case
  • In the document editor, is it normal that I cannot find the RERO authorities? For example this one (see screenshot).

image

  • The links to agents from the documents brief (public interface) view are broken. They point to /persons/ instead of /agents/.
  • The links to agents from the documents detailed view (public interface) work, but they should point to /agents/ instead of /contributions/.
  • The links to agents from the documents brief/detailed view (pro interface) work, but they should point to /agents/ instead of /persons/.

@Garfield-fr Garfield-fr force-pushed the zub-#1750-contribution branch from 58d08fc to 759fc8f Compare October 22, 2020 09:05
@Garfield-fr Garfield-fr changed the title contribution: refactoring to integrate organisation contribution: implements organisation agents Oct 22, 2020
@Garfield-fr Garfield-fr force-pushed the zub-#1750-contribution branch 10 times, most recently from cb634a3 to d02eadc Compare October 23, 2020 10:46
@Garfield-fr Garfield-fr force-pushed the zub-#1750-contribution branch 4 times, most recently from 5180245 to 90613c6 Compare November 6, 2020 06:02
@JoelleDosimont
Copy link

I just have one little remarks considering the punctuation marks (a cataloger's mania) : why is there a comma between the main and sub-corporate bodies instead of a dot ?
For example :
image

It should be a dot :
Suisse. Office fédéral de la statistique [idref]
Schweiz. Bundesamt für Statistik [gnd]
Suisse. Office fédéral de la statistique [RERO] --> this one is already correct

And in the variant access there is :
Office fédéral de la statistique, Suisse --> it should be : Office fédéral de la statistique (Suisse)
It's seems good in the original sources, but not in the MEF... It's maybe not so important, but it does seem strange for my cataloger's eyes...

@iGormilhit iGormilhit added the f: data About data model, importation, transformation, exportation of data, specific for bibliographic data label Nov 10, 2020

@Component({
selector: 'public-search-search-bar',
templateUrl: './search-bar.component.html',
styleUrls: ['./search-bar.component.css'],
Copy link
Contributor

@lauren-d lauren-d Nov 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1: projects/public-search/src/app/search-bar/search-bar.component.css is empty and could be removed

@jma jma force-pushed the zub-#1750-contribution branch from 90613c6 to b44ff8b Compare November 12, 2020 14:36
@iGormilhit iGormilhit modified the milestones: v0.14.0, v0.15.0 Nov 16, 2020
@Garfield-fr Garfield-fr assigned Garfield-fr and unassigned jma and rerowep Nov 16, 2020
@Garfield-fr Garfield-fr force-pushed the zub-#1750-contribution branch 2 times, most recently from 7d96129 to 2077e6d Compare November 16, 2020 07:44
@Garfield-fr Garfield-fr force-pushed the zub-#1750-contribution branch 2 times, most recently from 1e4484e to cb0ee5b Compare November 17, 2020 15:00
@Garfield-fr Garfield-fr modified the milestones: v0.15.0, v0.14.1 Nov 18, 2020
The shared folder allows you to share code between several projects.
The project tests have been adapted with the new structure of the Shared module.
Displays organisation agent data in the document brief and detailed view.
Allows the librarian to search for organisation agent authority record in the MEF server when cataloguing.

* Fixes patron history with status "In transit to house".
* Closes rero/rero-ils#1360

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr force-pushed the zub-#1750-contribution branch from cb0ee5b to 2dec386 Compare November 18, 2020 09:01
@Garfield-fr Garfield-fr merged commit da2d1a0 into rero:dev Nov 18, 2020
@Garfield-fr Garfield-fr deleted the zub-#1750-contribution branch November 18, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The loans in transit to house are not displayed in the patron history.
10 participants