Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circulation infos refactoring #405

Merged
merged 1 commit into from
Nov 4, 2020
Merged

circulation infos refactoring #405

merged 1 commit into from
Nov 4, 2020

Conversation

zannkukai
Copy link
Contributor

@zannkukai zannkukai commented Oct 28, 2020 •
edited
Loading

The message return by the backend when a user is blocked has changed.
This commit adapts the UI to this change and display the error message
returned by the backend directly.
This commit also adds counter on tabs of the patron circulation detail
page. Available counter are for checkin/checkout, pickup and pending
tabs.

Small correction on the template detail view.

Closes rero/rero-ils#1278
Closes rero/rero-ils#1281

Authored-by: Renaud Michotte renaud.michotte@gmail.com

Dependencies

How to test?

image

  • Use the professional interface to block a user.
  • Go in the circulation interface for this patron ; you should see this message in red (see screenshot)
  • Unblock the patron
  • Define some (small) limits on a patron_type and assign this patron_type to this patron
  • Do some checkout operation until the define limit is reached.
  • Reload the circulation interface for this patron : you should see a message in red.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@zannkukai zannkukai self-assigned this Oct 28, 2020
@iGormilhit iGormilhit changed the title Zan #1799 refactoring circulation infos circulation infos refactoring Oct 29, 2020
@zannkukai zannkukai force-pushed the zan-#1799-refactoring-circulation-infos branch 3 times, most recently from a0ccc23 to f0a4dc5 Compare October 30, 2020 09:48
@Garfield-fr
Copy link
Contributor

I consider the message system to be too large. Soon you don't see the important part.

@zannkukai zannkukai force-pushed the zan-#1799-refactoring-circulation-infos branch 2 times, most recently from e2c1be5 to e93540d Compare November 2, 2020 11:21
@zannkukai zannkukai force-pushed the US1643-borrow-limits branch from 5366517 to 6541f8c Compare November 2, 2020 11:23
@zannkukai zannkukai force-pushed the zan-#1799-refactoring-circulation-infos branch from e93540d to 82597e5 Compare November 2, 2020 11:23
@zannkukai zannkukai marked this pull request as ready for review November 2, 2020 11:24
@zannkukai zannkukai added this to the v0.14.0 (rero-ils) milestone Nov 2, 2020
@zannkukai zannkukai force-pushed the zan-#1799-refactoring-circulation-infos branch from 82597e5 to 7f95990 Compare November 2, 2020 14:00
@zannkukai zannkukai requested a review from Garfield-fr November 2, 2020 14:00
@zannkukai zannkukai force-pushed the zan-#1799-refactoring-circulation-infos branch from 7f95990 to 3e17dc8 Compare November 2, 2020 15:21
AoNoOokami
AoNoOokami suggested changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@AoNoOokami AoNoOokami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I create a patron type to add limits, clicking on one of the limit toggle switch activates Yearly subscription. I couldn't test further because of that.

limits

projects/admin/src/app/circulation/patron/card/card.component.ts Outdated Show resolved Hide resolved
@zannkukai zannkukai force-pushed the zan-#1799-refactoring-circulation-infos branch 2 times, most recently from b66a86d to 7bdc768 Compare November 2, 2020 16:10
@AoNoOokami
Copy link
Contributor

When I create a patron type to add limits, clicking on one of the limit toggle switch activates Yearly subscription. I couldn't test further because of that.

limits

Due to the wrong version of ng-core.

@AoNoOokami AoNoOokami self-requested a review November 3, 2020 08:54
@zannkukai zannkukai force-pushed the zan-#1799-refactoring-circulation-infos branch 2 times, most recently from f85fb7e to 3f0237f Compare November 3, 2020 12:31
iGormilhit
iGormilhit approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@zannkukai zannkukai force-pushed the US1643-borrow-limits branch from 6541f8c to eec8c6a Compare November 4, 2020 09:36
@zannkukai zannkukai force-pushed the zan-#1799-refactoring-circulation-infos branch from 3f0237f to 6c0f106 Compare November 4, 2020 09:38
@zannkukai
circulation: circulation infos refactoring.
ab27023 
The message returned by the backend when a user is blocked has changed.
This commit adapts the UI to this change and display the error message
returned by the backend directly.
This commit also adds counter on tabs of the patron circulation detailed
page. Available counters are for checkin/checkout, pickup and pending
tabs.

Small correction on the template detail view.

Closes rero/rero-ils#1278
Closes rero/rero-ils#1281

Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai force-pushed the zan-#1799-refactoring-circulation-infos branch from 6c0f106 to ab27023 Compare November 4, 2020 13:41
@zannkukai zannkukai merged commit 14feb64 into rero:US1643-borrow-limits Nov 4, 2020
@zannkukai zannkukai deleted the zan-#1799-refactoring-circulation-infos branch November 4, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AoNoOokami AoNoOokami AoNoOokami approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

Assignees

@zannkukai zannkukai

Labels
None yet
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zannkukai @Garfield-fr @AoNoOokami @iGormilhit