patron: allows librarians to update user password #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jma
force-pushed
the
maj-patron-change-password
branch
from
1a37f11
to
37160c6
Compare
6 tasks
jma
force-pushed
the
maj-patron-change-password
branch
from
37160c6
to
8ed6e06
Compare
Garfield-fr
approved these changes
Nov 4, 2020
| this.closeModal(); | ||
| }, | ||
| (resp) => { | ||
| console.log('Error: Update Patron Password', resp); |
There was a problem hiding this comment.
I think that it is to leave at is as it is displayed only when an error occurs. This can be useful. But if you want I can remove it.
| @@ -15,6 +15,10 @@ | |||
| along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| --> | |||
| <article *ngIf="currentPatron$ | async as patron"> | |||
| <div *ngIf="canUpdate()" class="float-right"> | |||
| <button [routerLink]="['/records','patrons','edit', patron.pid]" class="btn btn-sm btn-primary ml-1 ng-star-inserted" id="profile-edit-button" title="Edit"><i class="fa fa-pen mr-1"></i>{{ 'Edit' | translate }}</button> | |||
There was a problem hiding this comment.
COSMETIC: Too long. Multiple lines ?
There was a problem hiding this comment.
This is my default editor configuration... but I will do it.
| </ng-container> | ||
| </dd> | ||
| </dl> | ||
| <button *ngIf="canUpdate()" class="btn btn-sm btn-outline-primary mt-2" id="profile-change-password-button" (click)="updatePatronPassword(patron)" title="Change Password">{{ 'Change Password' | translate }}</button> |
There was a problem hiding this comment.
COSMETIC: Too long. Multiple lines ?
| <div *ngIf="canUpdate()" class="float-right"> | ||
| <button [routerLink]="['/records','patrons','edit', patron.pid]" class="btn btn-sm btn-primary ml-1 ng-star-inserted" id="profile-edit-button" title="Edit"><i class="fa fa-pen mr-1"></i>{{ 'Edit' | translate }}</button> | ||
| </div> | ||
| <h3 class="mb-3">{{ patron.last_name }} {{ patron.first_name }}</h3> |
There was a problem hiding this comment.
Optional case management for first name.
There was a problem hiding this comment.
Yes but for the moment the first_name is a required property. A lot of changes will be needed if we decide to make it optional.
jma
force-pushed
the
maj-patron-change-password
branch
2 times, most recently
from
1336ad7
to
5e070cb
Compare
AoNoOokami
reviewed
Nov 4, 2020
| @@ -46,11 +46,17 @@ export class UserService { | |||
| return this._allowInterfaceAccess; | |||
| } | |||
|
|
|||
| /** API Prefix, i.e. /api. */ | |||
| private _apiPrefix = ''; | |||
|
|
|||
| constructor( | |||
There was a problem hiding this comment.
Missing docstring for constructor
iGormilhit
suggested changes
Nov 5, 2020
There was a problem hiding this comment.
I think you can mention rero/rero-ils#1364 in your commit message.
Commit proposition, but check if it's correct:
patron: allows librarians to update user password
* Adds a button in the circulation patron profile to update the
password.
* Adds an edit button in the circulation patron profile.
* Displays patron role in the patron information of the circulation
module and in the patron detailed view.
* Allows searching patron by name in the checkout view, by searching in
all fields.
5e070cb
to
76f2b1b
Compare
jma
force-pushed
the
maj-patron-change-password
branch
from
76f2b1b
to
50b4fb6
Compare
iGormilhit
changed the title
iGormilhit
approved these changes
Nov 9, 2020
6 tasks
jma
force-pushed
the
maj-patron-change-password
branch
from
50b4fb6
to
a080c43
Compare
* Adds a button in the circulation patron profile to update the password. * Adds an edit button in the circulation patron profile. * Displays patron role in the patron information of the circulation profile and in the patron detailed view. * Sets a default value for the patron expiration date to now + 3 years. * Allows searching patron by name in the checkout view, by searching in all fields, closes rero/rero-ils#1364. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma
force-pushed
the
maj-patron-change-password
branch
from
a080c43
to
50fab80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
password.
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Why are you opening this PR?
Dependencies
How to test?
Code review check list