holdings: improve editor preview rendering #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
reviewed
Nov 4, 2020
| // only if the patterns changed | ||
| distinctUntilChanged((a, b) => JSON.stringify(a.patterns) === JSON.stringify(b.patterns)), | ||
| // cancel previous pending requests | ||
| switchMap(modelValue => this._editorService.getHoldingPatternPreview( |
There was a problem hiding this comment.
switchMap seems great and powerful !
There was a problem hiding this comment.
Exact! I put some comment on each, because I'm pretty sure that I will forget the meaning of each in few days...
zannkukai
approved these changes
Nov 4, 2020
iGormilhit
suggested changes
Nov 5, 2020
* Reduces the number of http calls when the form is modified. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma
force-pushed
the
maj-fix-multiple-http-holdings
branch
from
8c7ccf3
to
058d1d1
Compare
You are completely right. Thanks to read all our commit message and in particular my poor message quality! |
iGormilhit
changed the title
iGormilhit
approved these changes
Nov 5, 2020
sebdeleze
approved these changes
Nov 6, 2020
| @@ -43,34 +45,59 @@ export class HoldingEditorComponent { | |||
| /** Current error message from the backend during the serial preview example if exists */ | |||
| serialPreviewError = null; | |||
|
|
|||
| /** */ | |||
BadrAly
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Why are you opening this PR?
How to test?
Code review check list