circulation: improve displayed patron data #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
zan-#1837-adapt-card-component
branch
from
8b4549a
to
6a0a277
Compare
zannkukai
force-pushed
the
zan-#1837-adapt-card-component
branch
from
6a0a277
to
81851d6
Compare
sebdeleze
approved these changes
Nov 9, 2020
projects/admin/src/app/circulation/checkin/checkin.component.ts
Outdated
Show resolved
Hide resolved
iGormilhit
changed the title
* Adapts the link on the patron name depending where the card component is used: * In the checkin interface: point to the patron circulation view. * In the patron circulation view: point to the patron detail view. * Displays the patron age instead of birth date, to identify children easily + easter eggs. Closes rero/rero-ils#1378 Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-#1837-adapt-card-component
branch
from
81851d6
to
353c5e5
Compare
iGormilhit
approved these changes
Nov 9, 2020
iGormilhit
added
the
f: public ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending where the card component is sued, the link on the patron name
should be different :
Closes rero/rero-ils#1378
Authored-by: Renaud Michotte renaud.michotte@gmail.com
Why are you opening this PR?
Dependencies
My PR depends on
rero-ils#<xx>'s PR(s):How to test?
Code review check list