requests: improves the main request screen. #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
zan-refactoring-main-request
branch
2 times, most recently
from
9d52d62
to
2af6292
Compare
benerken
approved these changes
Nov 10, 2020
zannkukai
force-pushed
the
zan-refactoring-main-request
branch
from
2af6292
to
213f45a
Compare
iGormilhit
changed the title
iGormilhit
suggested changes
Nov 11, 2020
There was a problem hiding this comment.
Minor changes to the commit message:
requests: improves the main request screen
* Uses the same design for request than other item screens (pending item,
loaned items, ...).
* Adds a sort functionality to sort request.
* Adds an auto-refresh behavior on the requests list.
AoNoOokami
approved these changes
Nov 11, 2020
jma
requested changes
Nov 11, 2020
projects/admin/src/app/circulation/main-request/main-request.component.html
Outdated
Show resolved
Hide resolved
projects/admin/src/app/circulation/main-request/main-request.component.ts
Outdated
Show resolved
Hide resolved
projects/admin/src/app/circulation/main-request/main-request.component.ts
Show resolved
Hide resolved
projects/admin/src/app/circulation/main-request/main-request.component.ts
Outdated
Show resolved
Hide resolved
projects/admin/src/app/circulation/main-request/requested-item/requested-item.component.html
Show resolved
Hide resolved
projects/admin/src/app/circulation/main-request/requested-item/requested-item.component.ts
Show resolved
Hide resolved
projects/admin/src/app/circulation/main-request/requested-item/requested-item.component.ts
Show resolved
Hide resolved
projects/admin/src/app/circulation/main-request/requested-item/requested-item.component.ts
Outdated
Show resolved
Hide resolved
...in/src/app/circulation/main-request/requested-items-list/requested-items-list.component.html
Show resolved
Hide resolved
...dmin/src/app/circulation/main-request/requested-items-list/requested-items-list.component.ts
Outdated
Show resolved
Hide resolved
zannkukai
force-pushed
the
zan-refactoring-main-request
branch
3 times, most recently
from
01b47ee
to
01e14bb
Compare
* Uses the same design for request than other item screens (pending item, loaned items, ...). * Adds a sort functionality to sort request. * Adds an auto-refresh behavior on the requests list. Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-refactoring-main-request
branch
from
01e14bb
to
9f187d7
Compare
jma
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loaned items, ...).
Authored-by: Renaud Michotte renaud.michotte@gmail.com
Dependencies
rero/devfor the backendHow to test?
circulation/requestsCode review check list