Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circulation: improve labels #427

Merged
merged 1 commit into from
Nov 27, 2020
Merged

circulation: improve labels #427

merged 1 commit into from
Nov 27, 2020

Conversation

AoNoOokami
Copy link
Contributor

@AoNoOokami AoNoOokami commented Nov 11, 2020 •
edited
Loading

Thoses changes were asked by pilot libraries to make the interface
clearer.

Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on rero-ils#<xx>'s PR(s):

  • rero/rero-ils#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@AoNoOokami AoNoOokami added the f: circulation Concerns the circulation interface or backend label Nov 11, 2020
@AoNoOokami AoNoOokami added this to the v0.15.0 milestone Nov 11, 2020
@AoNoOokami AoNoOokami self-assigned this Nov 11, 2020
iGormilhit
iGormilhit reviewed Nov 12, 2020
View reviewed changes
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message:

  • to rename something into.
  • more clear → clearer.

@iGormilhit iGormilhit added the wording When text is concerned, label, message, actions… label Nov 17, 2020
@AoNoOokami AoNoOokami force-pushed the zaa-#1846-improve-circulation-labels branch from 61feb34 to 07c2cf3 Compare November 17, 2020 08:40
iGormilhit
iGormilhit approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@AoNoOokami AoNoOokami force-pushed the zaa-#1846-improve-circulation-labels branch from 07c2cf3 to dee47ca Compare November 25, 2020 14:26
circulation: improve labels
031cc3a 
* Renames checkin/checkout tab into 'on loan'.
* Renames 'Circulation' menu into 'Checkout/checkin'.
* Improves a placeholder.
* Adds a title to the checkin view.
* Closes rero/rero-ils#1280.

Thoses changes were asked by pilot libraries to make the interface
clearer.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami force-pushed the zaa-#1846-improve-circulation-labels branch from dee47ca to 031cc3a Compare November 27, 2020 09:46
@AoNoOokami AoNoOokami merged commit 6281159 into rero:dev Nov 27, 2020
@AoNoOokami AoNoOokami deleted the zaa-#1846-improve-circulation-labels branch December 4, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@zannkukai zannkukai zannkukai approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

Assignees

@AoNoOokami AoNoOokami

Labels
f: circulation Concerns the circulation interface or backend wording When text is concerned, label, message, actions…
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.

Put better labels for checkin/checkout pages
4 participants
@AoNoOokami @iGormilhit @zannkukai @lauren-d