Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: update PR template #428

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Conversation

AoNoOokami
Copy link
Contributor

  • Adds a check point about Cypress test in PR template.

Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch

Why are you opening this PR?

To remind people to run Cypress tests if relevant.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@AoNoOokami AoNoOokami self-assigned this Nov 11, 2020
@AoNoOokami AoNoOokami added this to the v0.15.0 milestone Nov 11, 2020
@iGormilhit iGormilhit added the dev: documentation About changelog, release notes, installation procedures, gh templates... label Nov 11, 2020
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a checkbox, not a checkpoint.

* Adds a check box about Cypress test in PR template.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami merged commit 1955d44 into rero:dev Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: documentation About changelog, release notes, installation procedures, gh templates...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants