Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: adapt templates for cypress tests #435

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

AoNoOokami
Copy link
Contributor

@AoNoOokami AoNoOokami commented Nov 17, 2020

  • Adds ids and names in the template to make element selection easier
    for Cypress tests.

Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on rero-ils#<xx>'s PR(s):

How to test?

See rero/rero-ils#1448

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@AoNoOokami AoNoOokami added this to the v0.14.1 milestone Nov 17, 2020
@AoNoOokami AoNoOokami self-assigned this Nov 17, 2020
@iGormilhit iGormilhit added the dev: tests For all types of tests: unit tests, e2e (Cypress)... label Nov 18, 2020
@AoNoOokami AoNoOokami removed the request for review from Garfield-fr November 18, 2020 08:45
* Adds ids and names in the template to make element selection easier
for Cypress tests.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami merged commit 2d6df2a into rero:dev Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: tests For all types of tests: unit tests, e2e (Cypress)...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants