document: display cover thumbnail #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
changed the base branch from
dev
to
zaa-US1812-metadata-document-types
AoNoOokami
force-pushed
the
zaa-#1867-document-types
branch
2 times, most recently
from
fdb748e to
49c663c
Compare
AoNoOokami
force-pushed
the
zaa-#1867-document-types
branch
2 times, most recently
from
a0459ae to
a35bd56
Compare
AoNoOokami
changed the title
zannkukai
requested changes
Nov 18, 2020
...ts/admin/src/app/record/detail-view/document-detail-view/document-detail-view.component.html
Outdated
Show resolved
Hide resolved
...ts/admin/src/app/record/detail-view/document-detail-view/document-detail-view.component.html
Outdated
Show resolved
Hide resolved
| for (const identifier of this.record.metadata.identifiedBy) { | ||
| if (identifier.type === 'bf:Isbn') { | ||
| this.isbn = identifier.value; | ||
| } | ||
| } |
There was a problem hiding this comment.
this.isbn = this.record.metadata.identifyBy
.filter(id => id.type === 'bf:Isbn') // keep only isbn
.map(id => id.value) // get identifier value
.find() // return the first array value or undefined if array is emptyTo be tested in real situation. For my point of view, it's more javascript minded (and if I had a good memory, it's more efficient for CPU)
Garfield-fr
reviewed
Nov 19, 2020
projects/shared/src/lib/view/thumbnail/thumbnail.component.html
Outdated
Show resolved
Hide resolved
| <header class="col-10"> | ||
| <div class="row mt-3 mb-3"> | ||
| <div class="col-2"> | ||
| <shared-thumbnail [record]="record"></shared-thumbnail> |
There was a problem hiding this comment.
Added the class parameter to be more flexible. The CSS definition stays in the main application.
...ts/admin/src/app/record/detail-view/document-detail-view/document-detail-view.component.html
Outdated
Show resolved
Hide resolved
...ts/admin/src/app/record/detail-view/document-detail-view/document-detail-view.component.html
Outdated
Show resolved
Hide resolved
projects/public-search/src/app/document-brief/document-brief.component.html
Show resolved
Hide resolved
projects/public-search/src/app/document-brief/document-brief.component.html
Show resolved
Hide resolved
iGormilhit
reviewed
Nov 19, 2020
iGormilhit
previously requested changes
Nov 19, 2020
AoNoOokami
force-pushed
the
zaa-#1867-document-types
branch
from
a35bd56 to
d396d5b
Compare
AoNoOokami
force-pushed
the
zaa-#1867-document-types
branch
2 times, most recently
from
f1167d4 to
d31713a
Compare
AoNoOokami
changed the title
AoNoOokami
force-pushed
the
zaa-#1867-document-types
branch
2 times, most recently
from
7b435c5 to
9b7994c
Compare
iGormilhit
approved these changes
Nov 23, 2020
zannkukai
approved these changes
Nov 23, 2020
AoNoOokami
force-pushed
the
zaa-#1867-document-types
branch
from
9b7994c to
34e1b07
Compare
AoNoOokami
force-pushed
the
zaa-#1867-document-types
branch
from
34e1b07 to
118659a
Compare
* Moves thumbnail logic in 'shared' library as it's used in both admin and public-search projects. * Adds thumbnails in professional brief and detailed view. * Moves 'type' field below the thumbnail in admin detailed view. * Closes rero/rero-ils#1188. Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami
force-pushed
the
zaa-#1867-document-types
branch
from
118659a to
5190a04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and public-search projects.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Why are you opening this PR?
To display thumbnails in brief and detail views of both admin and public parts of the application.
This is a part of US1812.
Dependencies
My PR depends on
rero-ils#<xx>'s PR(s):N/A
How to test?
Checkout this PR locally.
npm ito install shared librarynpm run start-admin-proxyto check admin partnpm run start-public-search-proxyto check public partCheck thumbnail display in both projects and both views (brief and detailed) on localhost:4200.
Code review check list