request: implement basic ILL request management #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
zan-#1849-create-ill-route
branch
3 times, most recently
from
dfe2a0e
to
a2cc713
Compare
iGormilhit
added
f: circulation
zannkukai
force-pushed
the
zan-#1849-create-ill-route
branch
from
a2cc713
to
384ba94
Compare
Garfield-fr
approved these changes
Nov 26, 2020
iGormilhit
suggested changes
Nov 26, 2020
There was a problem hiding this comment.
Commit message proposition:
request: implement basic ILL request management
Adds basic functionalities to manage the ILL requests into the
professional interface:
* Adds menu entry to list ILL requests (with faceting).
* Adds brief and detail views for ILL requests.
* Allows ILL request management (edit) by staff members.
* Allows ILL request creation by staff members.
* Implements an autocomplete typeahead widget on patron
resource.
I'm not sure with the last line. This autocomplete is used to find patrons through an editor (ie the ILL request creation form)? If so, "Implements an autocomplete typeahead widget to search for patrons in an editor select.", could be better.
zannkukai
force-pushed
the
zan-#1849-create-ill-route
branch
from
384ba94
to
047b4d6
Compare
zannkukai
force-pushed
the
zan-#1849-create-ill-route
branch
from
047b4d6
to
ce88180
Compare
iGormilhit
changed the title
iGormilhit
approved these changes
Nov 30, 2020
AoNoOokami
approved these changes
Nov 30, 2020
Adds basic functionalities to manage the ILL requests into the
professional interface:
* Adds menu entry to list ILL requests (with faceting).
* Adds brief and detail views for ILL requests.
* Allows ILL request management (edit) by staff members.
* Allows ILL request creation by staff members.
* Implements an autocomplete typeahead widget to search for patrons in
an editor select.
Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-#1849-create-ill-route
branch
from
ce88180
to
c587cbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic functionalities to manage the ill requests into the
professional interface :
This commit also implements an autocomplete typeahead widget on patron
resource.
Authored-by: Renaud Michotte renaud.michotte@gmail.com
Code review check list