editor: fix patron editor #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the patron editor, if the current edited patron doesn't have the 'patron' role, we need to remove all informations linked to this profile (mainly the default expiration_date set in `preprocessRecordEditor` function). Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-fix-patron-editor
branch
from
bb59378
to
4e86f30
Compare
zannkukai
requested review from
jma,
sebdeleze,
Garfield-fr and
iGormilhit
and removed request for
jma
Garfield-fr
requested changes
Nov 25, 2020
iGormilhit
added
f: editor
We can't do that because, in the editor we would like to display a default expiration date. If we move the default expiration date creation in the "postprocessRecordEditor", the field should be empty for user. |
Garfield-fr
approved these changes
Nov 25, 2020
iGormilhit
approved these changes
Nov 25, 2020
jma
approved these changes
Nov 25, 2020
lauren-d
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the patron editor, if the current edited patron doesn't have the
'patron' role, we need to remove all informations linked to this
profile (mainly the default expiration_date set in
preprocessRecordEditorfunction).Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
Code review check list