Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item: display item notes #454

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Conversation

zannkukai
Copy link
Contributor

Replaces the sticky icon by the note content into the document detailed
view.

Closes rero/rero-ils#1501

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

How to test?

image

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai self-assigned this Dec 3, 2020
@zannkukai zannkukai added this to the v1.0.0 milestone Dec 3, 2020
@iGormilhit iGormilhit added the f: professional ui Professional interface label Dec 3, 2020
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the commit message title, I think items is better than item.

Otherwise, the commit message is approved.

Replaces the sticky icon by the note content into the document detailed
view.

Closes rero/rero-ils#1501

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai merged commit c2996a3 into rero:dev Dec 8, 2020
@zannkukai zannkukai deleted the zan-notes-display branch December 8, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: professional ui Professional interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notes on items should be displayed in professional document detailed view
4 participants