-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
item: display item notes #454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
approved these changes
Dec 3, 2020
...l-view/document-detail-view/holding/default-holding-item/default-holding-item.component.html
Outdated
Show resolved
Hide resolved
...l-view/document-detail-view/holding/default-holding-item/default-holding-item.component.html
Outdated
Show resolved
Hide resolved
...l-view/document-detail-view/holding/default-holding-item/default-holding-item.component.html
Outdated
Show resolved
Hide resolved
...l-view/document-detail-view/holding/default-holding-item/default-holding-item.component.html
Outdated
Show resolved
Hide resolved
...l-view/document-detail-view/holding/default-holding-item/default-holding-item.component.html
Outdated
Show resolved
Hide resolved
...rd/detail-view/document-detail-view/holding/holding-item-note/holding-item-note.component.ts
Outdated
Show resolved
Hide resolved
...ail-view/document-detail-view/holding/serial-holding-item/serial-holding-item.component.html
Outdated
Show resolved
Hide resolved
...ail-view/document-detail-view/holding/serial-holding-item/serial-holding-item.component.html
Outdated
Show resolved
Hide resolved
...ail-view/document-detail-view/holding/serial-holding-item/serial-holding-item.component.html
Outdated
Show resolved
Hide resolved
...ail-view/document-detail-view/holding/serial-holding-item/serial-holding-item.component.html
Outdated
Show resolved
Hide resolved
iGormilhit
reviewed
Dec 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the commit message title, I think items
is better than item
.
Otherwise, the commit message is approved.
benerken
approved these changes
Dec 7, 2020
zannkukai
force-pushed
the
zan-notes-display
branch
from
December 7, 2020 13:49
c4290d9
to
2f57327
Compare
Replaces the sticky icon by the note content into the document detailed view. Closes rero/rero-ils#1501 Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-notes-display
branch
from
December 7, 2020 15:52
2f57327
to
09887fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the sticky icon by the note content into the document detailed
view.
Closes rero/rero-ils#1501
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
How to test?
Code review check list