menu: generation of menus by services #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
force-pushed
the
zub-app-menu
branch
7 times, most recently
from
678c8c3
to
1458924
Compare
Garfield-fr
force-pushed
the
zub-app-menu
branch
2 times, most recently
from
2bb2d2a
to
03a4044
Compare
Garfield-fr
requested review from
jma,
zannkukai,
lauren-d,
benerken and
iGormilhit
Garfield-fr
force-pushed
the
zub-app-menu
branch
3 times, most recently
from
694d15a
to
01f1289
Compare
iGormilhit
suggested changes
Dec 14, 2020
projects/admin/src/app/menu/menu-language/menu-language.component.html
Outdated
Show resolved
Hide resolved
projects/admin/src/app/menu/menu-dashboard/menu-dashboard.component.html
Outdated
Show resolved
Hide resolved
projects/admin/src/app/menu/menu-mobile/menu-mobile.component.html
Outdated
Show resolved
Hide resolved
projects/admin/src/app/menu/menu-mobile/menu-mobile.component.html
Outdated
Show resolved
Hide resolved
projects/admin/src/app/menu/menu-mobile/sub-menu/sub-menu.component.html
Outdated
Show resolved
Hide resolved
projects/admin/src/app/menu/menu-user-services/menu-user-services.component.html
Outdated
Show resolved
Hide resolved
Garfield-fr
force-pushed
the
zub-app-menu
branch
from
01f1289
to
b75e208
Compare
iGormilhit
approved these changes
Dec 14, 2020
zannkukai
reviewed
Dec 14, 2020
zannkukai
approved these changes
Dec 14, 2020
benerken
approved these changes
Dec 14, 2020
Garfield-fr
force-pushed
the
zub-app-menu
branch
from
b75e208
to
772e91e
Compare
jma
approved these changes
Dec 15, 2020
projects/admin/src/app/menu/menu-dashboard/menu-dashboard.component.html
Outdated
Show resolved
Hide resolved
projects/admin/src/app/menu/menu-dashboard/menu-dashboard.component.html
Show resolved
Hide resolved
projects/admin/src/app/menu/menu-mobile/sub-menu/sub-menu.component.html
Show resolved
Hide resolved
Menu refactoring to allow future easy addition of further entries. * Fixes url parsing on library switch. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr
force-pushed
the
zub-app-menu
branch
from
772e91e
to
1ae62c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Menu refactoring to allow future easy addition of further entries.
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
Code review check list