Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

holdings: fix holding detail page display #472

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

zannkukai
Copy link
Contributor

The 'add irregular issue' button had bad alignment with other page
components. This button is now on a specific row and right aligned.
The 'add local field' button is also right aligned.

Closes rero/rero-ils#1562

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

How to test?

image

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai added this to the v0.15.0 milestone Dec 15, 2020
@zannkukai zannkukai self-assigned this Dec 15, 2020
@iGormilhit iGormilhit added the f: professional ui Professional interface label Dec 15, 2020
The 'add irregular issue' button had bad alignment with other page
components. This button is now on a specific row and right aligned.
The 'add local field' button is also right aligned.

Closes rero/rero-ils#1562.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai merged commit 5a51666 into rero:dev Dec 15, 2020
@zannkukai zannkukai deleted the zan-fix-holding-detail branch December 15, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: professional ui Professional interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

holdings detailed view page is broken
4 participants