Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix templates for cypress tests #480

Merged
merged 1 commit into from
Jan 6, 2021
Merged

ui: fix templates for cypress tests #480

merged 1 commit into from
Jan 6, 2021

Conversation

AoNoOokami
Copy link
Contributor

  • Puts back some id html attribute that were removed. There are needed
    to keep Cypress tests working.

Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on rero-ils#<xx>'s PR(s):

  • rero/rero-ils#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

* Puts back some id html attribute that were removed. There are needed
to keep Cypress tests working.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami self-assigned this Jan 4, 2021
@AoNoOokami AoNoOokami changed the title ui: fix templates for cypress tests merge v1.0.0 branch Jan 4, 2021
@AoNoOokami AoNoOokami merged commit bf7c517 into dev Jan 6, 2021
@iGormilhit iGormilhit changed the title merge v1.0.0 branch ui: fix templates for cypress tests Jan 18, 2021
@AoNoOokami AoNoOokami deleted the v1.0.0 branch February 8, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant