documents: rewrite public holdings view in Angular #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
force-pushed
the
zub-holdings-items
branch
3 times, most recently
from
0a1e95c
to
775cef4
Compare
zannkukai
approved these changes
Jan 15, 2021
projects/public-search/src/app/document-detail/holdings/items/items.component.ts
Show resolved
Hide resolved
...public-search/src/app/document-detail/request/pickup-location/pickup-location.component.html
Outdated
Show resolved
Hide resolved
projects/public-search/src/app/document-detail/request/request.component.ts
Show resolved
Hide resolved
iGormilhit
suggested changes
Jan 18, 2021
There was a problem hiding this comment.
Commit proposition:
documents: rewrite public holdings view in Angular
* Implements the holdings section of the document detailed view of the
public interface to improve the user experience when loading holdings
with lots of items. With the JINJA templates, the performance is very
bad. Angular allows to lazy load data and will make easier to add
dynamic interaction between the user and the interface.
iGormilhit
changed the title
Garfield-fr
force-pushed
the
zub-holdings-items
branch
from
775cef4
to
69c26f5
Compare
Garfield-fr
force-pushed
the
zub-holdings-items
branch
from
69c26f5
to
6693f88
Compare
Garfield-fr
force-pushed
the
zub-holdings-items
branch
from
6693f88
to
0b9eab4
Compare
iGormilhit
approved these changes
Jan 19, 2021
Garfield-fr
force-pushed
the
zub-holdings-items
branch
from
0b9eab4
to
099ed62
Compare
* Implements the holdings section of the document detailed view of the public interface to improve the user experience when loading holdings with lots of items. With the JINJA templates, the performance is very bad. Angular allows to lazy load data and will make easier to add dynamic interaction between the user and the interface. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr
force-pushed
the
zub-holdings-items
branch
from
099ed62
to
5909071
Compare
iGormilhit
added
the
f: public ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
public interface to improve the user experience when loading holdings
with lots of items. With the JINJA templates, the performance is very
bad. Angular allows to lazy load data and will make easier to add
dynamic interaction between the user and the interface.
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
Why are you opening this PR?
Dependencies
My PR depends on
rero-ils#1611's PR(s):How to test?
Code review check list