Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

items: add temporary circulation category #494

Merged
merged 1 commit into from
Jan 25, 2021
Merged

items: add temporary circulation category #494

merged 1 commit into from
Jan 25, 2021

Conversation

zannkukai
Copy link
Contributor

Updates the item route definition to use a 'long mode' editor for items.
Updates item brief/detailed templates to add the temporary circulation
category information.

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

Dependencies

rero/rero-ils#1606

How to test?

  • Add a temporary circulation category (tmp_itty) on an item.
  • Try to display the document detailed view for this item
  • Try to display the item detail view for this item.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai self-assigned this Jan 19, 2021
@zannkukai zannkukai added this to the v1.0.0 milestone Jan 19, 2021
@zannkukai zannkukai requested a review from Garfield-fr January 19, 2021 08:46
iGormilhit
iGormilhit approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@zannkukai zannkukai requested a review from AoNoOokami January 20, 2021 07:31
@iGormilhit iGormilhit added f: circulation Concerns the circulation interface or backend f: data About data model, importation, transformation, exportation of data, specific for bibliographic data labels Jan 20, 2021
@zannkukai
items: add temporary circulation category
023de06 
Updates the item route definition to use a 'long mode' editor for items.
Updates item brief/detailed templates to add the temporary circulation
category information.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai merged commit c218163 into rero:dev Jan 25, 2021
@zannkukai zannkukai deleted the zan-ui-tmp-itty branch January 25, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@AoNoOokami AoNoOokami AoNoOokami approved these changes

Assignees

@zannkukai zannkukai

Labels
f: circulation Concerns the circulation interface or backend f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zannkukai @Garfield-fr @iGormilhit @AoNoOokami