libraries: add notification settings #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
force-pushed
the
zaa-#2013-printing-email
branch
3 times, most recently
from
4781212 to
bdf7ca9
Compare
AoNoOokami
force-pushed
the
zaa-#2013-printing-email
branch
7 times, most recently
from
6fd7b2f to
791322d
Compare
AoNoOokami
requested review from
zannkukai,
jma and
lauren-d
and removed request for
jma
AoNoOokami
force-pushed
the
zaa-#2013-printing-email
branch
from
791322d to
a64e246
Compare
zannkukai
requested changes
Feb 23, 2021
| public organisationPid: string; | ||
|
|
||
| /** List of internal notification types */ | ||
| internalTypes = ['booking', 'request', 'transit_notice']; |
There was a problem hiding this comment.
Should be set in a Enum class into class/library.ts file. As ItemStatus, or NoteType
jma
force-pushed
the
zaa-#2013-printing-email
branch
from
a64e246 to
960a044
Compare
jma
force-pushed
the
zaa-#2013-printing-email
branch
from
960a044 to
6f0b99a
Compare
jma
requested review from
zannkukai and
Garfield-fr
and removed request for
lauren-d
Garfield-fr
reviewed
Mar 12, 2021
| @@ -19,9 +19,14 @@ | |||
| // required as json properties is not lowerCamelCase | |||
|
|
|||
| import { WeekDay } from '@angular/common'; | |||
| import { marker } from '@biesbjerg/ngx-translate-extract-marker'; | |||
There was a problem hiding this comment.
import { marker as _ } from '@biesbjerg/ngx-translate-extract-marker';
There was a problem hiding this comment.
Unfortunately this does not works with the tests.
Comment on lines
+26
to
+30
| export function _(str) { | ||
| return marker(str); | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggestion: Remove this (test extraction)
|
|
||
| /** Observable for build event */ | ||
| private buildEvent = new Subject(); | ||
|
|
||
| constructor( |
| @@ -29,14 +31,22 @@ export class LibraryFormService { | |||
|
|
|||
| public form; | |||
|
|
|||
|
|
|||
| private notificationTypes = []; | |||
|
|
||
| /** | ||
| * Build form | ||
| */ | ||
| build() { |
| @@ -140,6 +238,9 @@ export class LibraryFormService { | |||
| get opening_hours() { | |||
| return this.form.get('opening_hours') as FormArray; | |||
| } | |||
| get notification_settings() { | |||
| return this.form.get('notification_settings') as FormArray; | |||
| } | |||
|
|
|||
| getValues() { return this.form.value; } | |||
| public organisationPid; | ||
| public organisationPid: string; | ||
|
|
||
| private eventForm: Subscription; |
| public organisationPid; | ||
| public organisationPid: string; | ||
|
|
||
| private eventForm: Subscription; | ||
|
|
||
| constructor( |
| }); | ||
| } | ||
|
|
||
| ngOnDestroy() { |
There was a problem hiding this comment.
Missing doc string and add return type
Comment on lines
22
to
24
| <dt class="col-sm-3 offset-sm-2 offset-md-0"> | ||
| {{ 'Address' | translate }}: | ||
| </dt> |
There was a problem hiding this comment.
<dt class="col-sm-3 offset-sm-2 offset-md-0 label-title" translate>
Address
</dt>
There was a problem hiding this comment.
Great. I didn't now that this exists. Needs refactor other files in a separate PR.
zannkukai
approved these changes
Mar 12, 2021
jma
force-pushed
the
zaa-#2013-printing-email
branch
from
6f0b99a to
e3a8e3b
Compare
jma
force-pushed
the
zaa-#2013-printing-email
branch
from
e3a8e3b to
590ef80
Compare
* Improves library editor appearance for large screens. It doesn't take the full width anymore. * Adds tabs in the library detailed view. * Adds notifications settings in library custom editor. * Displays notification settings in library detail view. Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch> Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
jma
force-pushed
the
zaa-#2013-printing-email
branch
from
590ef80 to
e2267fd
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the full width anymore.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Co-Authored-by: Johnny Mariéthoz johnny.mariethoz@rero.ch
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Why are you opening this PR?
To implement task 2013 of US1922 https://tree.taiga.io/project/rero21-reroils/us/1922?milestone=282105
Dependencies
How to test?
Code review check list