libraries: add notification settings #516

AoNoOokami · 2021-02-10T16:06:56Z

Improves library editor appearance for large screens. It doesn't take
the full width anymore.
Adds tabs in the library detailed view.
Adds notifications settings in library custom editor.
Displays notification settings in library detail view.

Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Co-Authored-by: Johnny Mariéthoz johnny.mariethoz@rero.ch
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch

Why are you opening this PR?

To implement task 2013 of US1922 https://tree.taiga.io/project/rero21-reroils/us/1922?milestone=282105

Dependencies

libraries: add notification settings in library definition rero-ils#1691

How to test?

What command should I have to run to test your PR?
What should I test through the UI?

Code review check list

zannkukai · 2021-02-23T08:06:35Z

projects/admin/src/app/record/custom-editor/libraries/library.component.ts

+  public organisationPid: string;
+
+  /** List of internal notification types */
+  internalTypes = ['booking', 'request', 'transit_notice'];


Should be set in a Enum class into class/library.ts file. As ItemStatus, or NoteType

Garfield-fr

With the new version of Angular, it is recommended to type the return of the function.
General: Add documentation on functions

Garfield-fr · 2021-03-12T05:11:14Z

projects/admin/src/app/classes/library.ts

@@ -19,9 +19,14 @@
 // required as json properties is not lowerCamelCase

 import { WeekDay } from '@angular/common';
+import { marker } from '@biesbjerg/ngx-translate-extract-marker';


import { marker as _ } from '@biesbjerg/ngx-translate-extract-marker';

Unfortunately this does not works with the tests.

Garfield-fr · 2021-03-12T05:11:24Z

projects/admin/src/app/classes/library.ts

+export function _(str) {
+  return marker(str);
+}
+


Suggestion: Remove this (test extraction)

Garfield-fr · 2021-03-12T05:12:42Z

projects/admin/src/app/record/custom-editor/libraries/library-form.service.ts

+
+  /** Observable for build event */
+  private buildEvent = new Subject();
+
  constructor(


Missing doc string

Garfield-fr · 2021-03-12T05:12:53Z

projects/admin/src/app/record/custom-editor/libraries/library-form.service.ts

@@ -29,14 +31,22 @@ export class LibraryFormService {

  public form;

+
+  private notificationTypes = [];


missing doc string

Garfield-fr · 2021-03-12T05:13:18Z

projects/admin/src/app/record/custom-editor/libraries/library-form.service.ts


+  /**
+   * Build form
+   */
  build() {


build(): void {

Garfield-fr · 2021-03-12T05:21:16Z

projects/admin/src/app/record/custom-editor/libraries/library-form.service.ts

@@ -140,6 +238,9 @@ export class LibraryFormService {
  get opening_hours() {
    return this.form.get('opening_hours') as FormArray;
  }
+  get notification_settings() {
+    return this.form.get('notification_settings') as FormArray;
+  }

  getValues() { return this.form.value; }


add return type

Garfield-fr · 2021-03-12T05:21:34Z

projects/admin/src/app/record/custom-editor/libraries/library.component.ts

-  public organisationPid;
+  public organisationPid: string;
+
+  private eventForm: Subscription;


Missing doc string

Garfield-fr · 2021-03-12T05:21:46Z

projects/admin/src/app/record/custom-editor/libraries/library.component.ts

-  public organisationPid;
+  public organisationPid: string;
+
+  private eventForm: Subscription;

  constructor(


Missing doc string

Garfield-fr · 2021-03-12T05:22:03Z

projects/admin/src/app/record/custom-editor/libraries/library.component.ts

    });
  }

+  ngOnDestroy() {


Missing doc string and add return type

Garfield-fr · 2021-03-12T05:25:23Z

...ects/admin/src/app/record/detail-view/library-detail-view/library-detail-view.component.html

+      <dt class="col-sm-3 offset-sm-2 offset-md-0">
+        {{ 'Address' | translate }}:
+      </dt>


<dt class="col-sm-3 offset-sm-2 offset-md-0 label-title" translate> Address </dt>

Great. I didn't now that this exists. Needs refactor other files in a separate PR.

zannkukai

No other remarks than @Garfield-fr

* Improves library editor appearance for large screens. It doesn't take the full width anymore. * Adds tabs in the library detailed view. * Adds notifications settings in library custom editor. * Displays notification settings in library detail view. Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch> Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>

AoNoOokami added this to the v1.1.0 milestone Feb 10, 2021

AoNoOokami self-assigned this Feb 10, 2021

AoNoOokami force-pushed the zaa-#2013-printing-email branch 3 times, most recently from 4781212 to bdf7ca9 Compare February 15, 2021 13:59

AoNoOokami added the f: notifications label Feb 16, 2021

AoNoOokami force-pushed the zaa-#2013-printing-email branch 7 times, most recently from 6fd7b2f to 791322d Compare February 22, 2021 10:08

AoNoOokami marked this pull request as ready for review February 22, 2021 15:07

AoNoOokami requested review from zannkukai, jma and lauren-d and removed request for jma February 22, 2021 15:07

AoNoOokami force-pushed the zaa-#2013-printing-email branch from 791322d to a64e246 Compare February 23, 2021 07:50

zannkukai requested changes Feb 23, 2021

View reviewed changes

iGormilhit modified the milestones: v1.1.0, v1.0.2 Mar 1, 2021

jma force-pushed the zaa-#2013-printing-email branch from a64e246 to 960a044 Compare March 11, 2021 14:17

jma self-requested a review March 11, 2021 14:22

jma force-pushed the zaa-#2013-printing-email branch from 960a044 to 6f0b99a Compare March 11, 2021 14:39

jma requested review from zannkukai and Garfield-fr and removed request for lauren-d March 11, 2021 16:32

Garfield-fr reviewed Mar 12, 2021

View reviewed changes

zannkukai approved these changes Mar 12, 2021

View reviewed changes

jma force-pushed the zaa-#2013-printing-email branch from 6f0b99a to e3a8e3b Compare March 15, 2021 07:44

jma requested a review from Garfield-fr March 15, 2021 07:44

jma force-pushed the zaa-#2013-printing-email branch from e3a8e3b to 590ef80 Compare March 15, 2021 08:31

jma force-pushed the zaa-#2013-printing-email branch from 590ef80 to e2267fd Compare March 15, 2021 09:14

jma mentioned this pull request Mar 15, 2021

libraries: add notification settings in library definition rero/rero-ils#1691

Merged

7 tasks

jma merged commit 65e84b4 into rero:dev Mar 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libraries: add notification settings #516

libraries: add notification settings #516

AoNoOokami commented Feb 10, 2021 •

edited by jma

Loading

zannkukai Feb 23, 2021

Garfield-fr left a comment

Garfield-fr Mar 12, 2021

jma Mar 15, 2021

Garfield-fr Mar 12, 2021

Garfield-fr Mar 12, 2021

Garfield-fr Mar 12, 2021

Garfield-fr Mar 12, 2021

Garfield-fr Mar 12, 2021

Garfield-fr Mar 12, 2021

Garfield-fr Mar 12, 2021

Garfield-fr Mar 12, 2021

Garfield-fr Mar 12, 2021

jma Mar 15, 2021

zannkukai left a comment

		@@ -29,14 +31,22 @@ export class LibraryFormService {

		public form;


		private notificationTypes = [];

libraries: add notification settings #516

libraries: add notification settings #516

Conversation

AoNoOokami commented Feb 10, 2021 • edited by jma Loading

Why are you opening this PR?

Dependencies

How to test?

Code review check list

Choose a reason for hiding this comment

Garfield-fr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zannkukai left a comment

Choose a reason for hiding this comment

AoNoOokami commented Feb 10, 2021 •

edited by jma

Loading