circulation: improve library closed dates handling #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
added
f: circulation
zannkukai
force-pushed
the
zan-library-closed-date
branch
2 times, most recently
from
c279727
to
1e9771c
Compare
zannkukai
requested review from
Garfield-fr,
lauren-d,
rerowep and
jma
and removed request for
rerowep
jma
approved these changes
Mar 1, 2021
projects/admin/src/app/circulation/patron/loan/fixed-date-form/fixed-date-form.component.ts
Show resolved
Hide resolved
iGormilhit
suggested changes
Mar 1, 2021
iGormilhit
changed the title
iGormilhit
added
f: professional ui
zannkukai
force-pushed
the
zan-library-closed-date
branch
from
1e9771c
to
ce5e918
Compare
zannkukai
force-pushed
the
zan-library-closed-date
branch
from
ce5e918
to
347e9c3
Compare
* Uses the back end closed dates library API to prevent the user to choose a closed date for a fixed date checkout. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-library-closed-date
branch
from
347e9c3
to
4a5bf4c
Compare
Garfield-fr
approved these changes
Mar 10, 2021
sebdeleze
approved these changes
Mar 10, 2021
Comment on lines
+47
to
+48
| map((data: any) => data.closed_dates), | ||
| map((dates: [string]) => dates.map(dateStr => moment(dateStr))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the backend closed dates library API to disallow user to choose a
closed date for a fixed date checkout.
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
How to test?
Code review check list