patrons: add a role async validator #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Garfield-fr
approved these changes
Apr 15, 2021
| * | ||
| * @param field - formly field config. | ||
| */ | ||
| _getRoleValidator(field: FormlyFieldConfig) { |
| _getRoleValidator(field: FormlyFieldConfig) { | ||
| return { | ||
| expression: (control: FormControl) => { | ||
| console.log('validate'); |
jma
force-pushed
the
maj-patron-role-validator
branch
3 times, most recently
from
fc3dc2e
to
74454d8
Compare
Garfield-fr
approved these changes
Apr 15, 2021
| * | ||
| * @param field - formly field config. | ||
| */ | ||
| private _getRoleValidator(field: FormlyFieldConfig) { |
There was a problem hiding this comment.
output typing: Observable<Boolean> ?
zannkukai
approved these changes
Apr 15, 2021
Comment on lines
+137
to
+142
| if (ptrn.organisation.pid !== currentOrgPid) { | ||
| if (ptrn.roles.some(role => ['librarian', 'system_librarian'].some(r => r === role))) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; |
There was a problem hiding this comment.
merged ?
return (ptrn.organisation.pid !== currentOrgPid) && (ptrn.roles.some(role => ['librarian', 'system_librarian'].some(r => r === role)));
jma
force-pushed
the
maj-patron-role-validator
branch
from
74454d8
to
85de364
Compare
jma
force-pushed
the
maj-patron-role-validator
branch
2 times, most recently
from
a4c1d56
to
0c226e6
Compare
* Removes useless console log messages. * Adds a role patron editor validator to avoid multiple professional accounts. * Fixes spelling: constributionSources -> contributionSources. Co-Authored-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
jma
force-pushed
the
maj-patron-role-validator
branch
from
0c226e6
to
34ca3ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accounts
For reviewer
Only the last commit.
Why are you opening this PR?
Dependencies
How to test?
Code review check list