Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documents: update field display #591

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented May 5, 2021

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Why are you opening this PR?

How to test?

  • Check summary field on document detail view.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@Garfield-fr Garfield-fr self-assigned this May 5, 2021
@Garfield-fr Garfield-fr added this to the v1.3.0 milestone May 5, 2021
@Garfield-fr Garfield-fr force-pushed the zub-document-remove-fields branch 5 times, most recently from f49f4b8 to 81d6e8f Compare May 5, 2021 08:21
@Garfield-fr Garfield-fr added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: professional ui Professional interface labels May 5, 2021
@iGormilhit iGormilhit changed the title documents: summary field documents: update field display May 10, 2021
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message title: documents: update field display.

@Garfield-fr Garfield-fr force-pushed the zub-document-remove-fields branch 2 times, most recently from c150df6 to d4cd283 Compare May 11, 2021 13:03
@jma jma removed their request for review June 2, 2021 11:26
* Removes abstract and titlesProper fields.
* Adds summary fields.
* Closes rero/rero-ils#1620.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr merged commit e671bb8 into rero:dev Jun 8, 2021
@Garfield-fr Garfield-fr deleted the zub-document-remove-fields branch June 8, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: professional ui Professional interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit document fields titlesProper, translatedFrom, abstracts (are newly implemented)
4 participants