Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patrons: implement detail view #60

Merged
merged 1 commit into from
Dec 6, 2019
Merged

patrons: implement detail view #60

merged 1 commit into from
Dec 6, 2019

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Dec 4, 2019 •
edited
Loading

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Why are you opening this PR?

  • Adds detail view.
  • Adds link on brief view to patron name.
  • Adds patron service.
  • Adds translations.
  • Fixes facet roles is open by default

How to test?

  • Check patron section on admin view

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

AoNoOokami
AoNoOokami reviewed Dec 4, 2019
View reviewed changes
Copy link
Contributor

@AoNoOokami AoNoOokami left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got this error when loading patrons brief view:
Screen Shot 2019-12-04 at 16 34 41

@Garfield-fr
patrons: implement detail view
bb31bab 
* Adds detail view.
* Adds link on brief view to patron name.
* Adds patron service.
* Adds translations.
* Fixes facet roles is open by default

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr merged commit 517d7de into rero:dev Dec 6, 2019
@Garfield-fr Garfield-fr deleted the zub-patron-detail-view branch December 6, 2019 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@AoNoOokami AoNoOokami AoNoOokami approved these changes

@zannkukai zannkukai zannkukai approved these changes

@sebdeleze sebdeleze sebdeleze approved these changes

@jma jma Awaiting requested review from jma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Garfield-fr @sebdeleze @zannkukai @AoNoOokami @lauren-d