admin & public-search: add missing translations #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
AoNoOokami
force-pushed
the
zaa-missing-translations
branch
from
2f505be
to
64aba54
Compare
AoNoOokami
requested review from
Garfield-fr,
jma,
blankoworld,
BadrAly,
benerken,
lauren-d and
zannkukai
zannkukai
approved these changes
Dec 4, 2019
Garfield-fr
approved these changes
Dec 4, 2019
lauren-d
approved these changes
Dec 4, 2019
AoNoOokami
force-pushed
the
zaa-missing-translations
branch
from
64aba54
to
5f34dfb
Compare
Garfield-fr
approved these changes
Dec 4, 2019
AoNoOokami
force-pushed
the
zaa-missing-translations
branch
from
5f34dfb
to
68197fe
Compare
* Adds missing translations. Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami
force-pushed
the
zaa-missing-translations
branch
from
68197fe
to
8a9defd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Why are you opening this PR?
Part of #43
Closes points 10, 18, 20 and 31.
How to test?
Check menu and editor translations in admin app.
Check facets translations in public search app.
Code review check list