Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circulation: display circulation messages #620

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

zannkukai
Copy link
Contributor

Display circulation messages (blocked, max item checkout, ...) related
to the loaded patrons on the patron circulation view.

Closes rero/rero-ils#1964.

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

How to test?

  • Edit a "patron" user ; block it for some reasons.
  • Go to the circulation view of this patron.
  • The block message will be displayed.

image

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai added bug Breaks something, but is not blocking. f: circulation Concerns the circulation interface or backend labels Jun 7, 2021
@zannkukai zannkukai self-assigned this Jun 7, 2021
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message body: s/(blocked, max item checkout, ...)/(blocked, max item checkout…)/

Display circulation messages (blocked, max item checkout...) related
to the loaded patrons on the patron circulation view.

Closes rero/rero-ils#1964.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai merged commit af24d39 into rero:dev Jun 9, 2021
@zannkukai zannkukai deleted the zan-fix-issue-1964 branch June 9, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something, but is not blocking. f: circulation Concerns the circulation interface or backend f: professional ui Professional interface f: user management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No more warning on checkout page for a blocked patron
4 participants