ui: fix language setting on the public interface #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
f: public ui
Garfield-fr
force-pushed
the
zub-public-language-fix
branch
2 times, most recently
from
7b3b82b
to
95f513f
Compare
iGormilhit
suggested changes
Jun 16, 2021
There was a problem hiding this comment.
Commit message:
ui: fix language setting on the public interface
* Fixes the current language on public interface.
* Improves center the text above thumbnail on document brief view.
* Moves the document availability at the end of the metadata of the
document brief view.
* Closes rero/rero-ils#1391.
Garfield-fr
force-pushed
the
zub-public-language-fix
branch
from
95f513f
to
3b68672
Compare
Garfield-fr
changed the title
Garfield-fr
requested review from
iGormilhit,
benerken,
lauren-d,
sebdeleze and
zannkukai
iGormilhit
approved these changes
Jun 16, 2021
sebdeleze
approved these changes
Jun 16, 2021
| @@ -31,16 +33,36 @@ export class AppInitializerService { | |||
| */ | |||
* Fixes the current language on public interface. * Improves center the text above thumbnail on document brief view. * Moves the document availability at the end of the metadata of the document brief view. * Closes rero/rero-ils#1391. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr
force-pushed
the
zub-public-language-fix
branch
from
3b68672
to
63a1bf8
Compare
jma
approved these changes
Jun 16, 2021
| this._userService.load(); | ||
| this._routeCollectionService.load(); | ||
| resolve(true); | ||
| }); | ||
| } | ||
|
|
||
| /** Initialize Translate Service */ | ||
| private initTranslateService(): void { |
There was a problem hiding this comment.
can be one day in the shared or ng-core
There was a problem hiding this comment.
For the next refactoring ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document brief view.
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
Code review check list