libraries: correct code display #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Corrects code display when there is no address. * Hide exception hours bloc if empty. Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami
force-pushed
the
zaa-library-code-display
branch
from
5804c7c
to
133f427
Compare
AoNoOokami
requested review from
Garfield-fr,
jma,
benerken,
blankoworld,
iGormilhit,
lauren-d,
sebdeleze and
zannkukai
lauren-d
approved these changes
Dec 4, 2019
zannkukai
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Why are you opening this PR?
To correct libraries detail view.
Part of #43
How to test?
Create a library without address and exception hours and check code is correctly displayed and exception hours bloc is hidden.
Code review check list