Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

items: implement circulation history #653

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Jul 1, 2021

  • Displays the circulation history of the item on
    the item detailed view of the professional interface.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Display

history

How to test?

  • Check circulation history on item

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@github-actions github-actions bot added the f: professional ui Professional interface label Jul 1, 2021
@iGormilhit iGormilhit changed the title item: circulation history items: implement circulation history Jul 1, 2021
@Garfield-fr Garfield-fr added this to the v1.5.0 milestone Jul 1, 2021
@Garfield-fr Garfield-fr self-assigned this Jul 1, 2021
@Garfield-fr Garfield-fr force-pushed the zub-item-circulation-history branch from cfd695a to a5e29f0 Compare July 1, 2021 06:50
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message proposition:

items: implement circulation history

* Displays the circulation history of the item on the item detailed view of the professional interface.

@Garfield-fr Garfield-fr force-pushed the zub-item-circulation-history branch 2 times, most recently from 497b01a to fc7fe62 Compare July 1, 2021 06:52
@Garfield-fr Garfield-fr requested a review from iGormilhit July 1, 2021 06:53
@Garfield-fr Garfield-fr force-pushed the zub-item-circulation-history branch 3 times, most recently from 7a2ae05 to f988139 Compare July 1, 2021 08:10
Copy link
Contributor

@zannkukai zannkukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works, so I approve.
But I'm not agree with using em instead of col-x for the display. Should be corrected later

@Garfield-fr Garfield-fr force-pushed the zub-item-circulation-history branch from f988139 to 7e28c7f Compare July 1, 2021 10:20
@pronguen
Copy link
Contributor

pronguen commented Jul 1, 2021

@Garfield-fr Thanks, it works fine!

One improvement if it is easy to realise:

  • Can we filter and remove from the "circulation history" all the cancel actions? They are automatically done by the system and it would not be understood by a librarian.
    image
  • Can we display 10 logs instead of 5? It would be better, but I don't know if this impacts too much the performance. (For the holdings and items as well, 5 is too low, but this is another subject!)
  • Is the ({{ counter }} hidden circulations logs) due to translations?

I could not test with an anonymised log... this functionality really does not work well.

* Displays the circulation history of the item on
the item detailed view of the professional interface.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr force-pushed the zub-item-circulation-history branch from 7e28c7f to 3a67dde Compare July 1, 2021 13:04
@Garfield-fr Garfield-fr merged commit eddbb75 into rero:dev Jul 1, 2021
@Garfield-fr Garfield-fr modified the milestones: v1.5.0, v.1.4.0 Jul 1, 2021
@Garfield-fr Garfield-fr deleted the zub-item-circulation-history branch July 1, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: professional ui Professional interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants