circulation: improve requested loans tab #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
f: circulation
Garfield-fr
force-pushed
the
zub-circulation-request
branch
from
ca9f554
to
39e70dc
Compare
Garfield-fr
changed the title
sebdeleze
approved these changes
Jul 14, 2021
projects/admin/src/app/circulation/main-request/requested-item/requested-item.component.html
Outdated
Show resolved
Hide resolved
Garfield-fr
force-pushed
the
zub-circulation-request
branch
from
39e70dc
to
d36c625
Compare
zannkukai
reviewed
Jul 14, 2021
Comment on lines
-79
to
-81
| <span class="badge badge-info"> | ||
| {{ item.loan.rank }} / {{ item.pending_loans.length }} | ||
| </span> |
There was a problem hiding this comment.
RiP my beautiful rank :'(
zannkukai
approved these changes
Jul 14, 2021
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr
force-pushed
the
zub-circulation-request
branch
from
d36c625
to
5107499
Compare
iGormilhit
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
Code review check list