Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documents: display all fields on the detail view #679

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Jul 22, 2021

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Why are you opening this PR?

  • Add some fields.

How to test?

  • Add data to some fields and check the display on "Header" and "Description" tab

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@github-actions github-actions bot added the f: professional ui Professional interface label Jul 22, 2021
@Garfield-fr Garfield-fr force-pushed the zub-all-fields branch 2 times, most recently from 2221918 to 2c7f4cd Compare July 22, 2021 06:34
@iGormilhit iGormilhit changed the title documents: implement all fields on the detail view documents: dispaly all fields on the detail view Jul 22, 2021
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message title proposition: documents: display all fields on the detail view

@Garfield-fr Garfield-fr changed the title documents: dispaly all fields on the detail view documents: display all fields on the detail view Jul 22, 2021
@iGormilhit iGormilhit added this to the v1.5.0 milestone Jul 22, 2021
@Garfield-fr Garfield-fr force-pushed the zub-all-fields branch 2 times, most recently from 50a74e3 to 7a6d85a Compare July 22, 2021 07:47
@Garfield-fr Garfield-fr self-assigned this Jul 22, 2021
@Garfield-fr Garfield-fr marked this pull request as draft July 29, 2021 14:51
@Garfield-fr Garfield-fr modified the milestones: v1.5.0, v1.6.0 Jul 29, 2021
@Garfield-fr Garfield-fr modified the milestones: v1.6.0, v1.5.0 Aug 4, 2021
@Garfield-fr Garfield-fr marked this pull request as ready for review August 4, 2021 09:01
@Garfield-fr Garfield-fr force-pushed the zub-all-fields branch 3 times, most recently from 395414f to b9cb3bb Compare August 10, 2021 14:07
@Garfield-fr Garfield-fr force-pushed the zub-all-fields branch 3 times, most recently from 6571648 to 0ce5162 Compare August 17, 2021 13:11
@Garfield-fr Garfield-fr force-pushed the zub-all-fields branch 4 times, most recently from 735aad8 to 164858d Compare September 16, 2021 05:26
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr changed the base branch from dev to v0.16.14 September 21, 2021 08:27
@Garfield-fr Garfield-fr merged commit 2121339 into rero:v0.16.14 Sep 21, 2021
@Garfield-fr Garfield-fr deleted the zub-all-fields branch March 14, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: professional ui Professional interface f: search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants