-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documents: display all fields on the detail view #679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
force-pushed
the
zub-all-fields
branch
2 times, most recently
from
July 22, 2021 06:34
2221918
to
2c7f4cd
Compare
iGormilhit
changed the title
documents: implement all fields on the detail view
documents: dispaly all fields on the detail view
Jul 22, 2021
iGormilhit
suggested changes
Jul 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message title proposition: documents: display all fields on the detail view
Garfield-fr
force-pushed
the
zub-all-fields
branch
from
July 22, 2021 06:58
2c7f4cd
to
264d333
Compare
Garfield-fr
changed the title
documents: dispaly all fields on the detail view
documents: display all fields on the detail view
Jul 22, 2021
iGormilhit
approved these changes
Jul 22, 2021
Garfield-fr
force-pushed
the
zub-all-fields
branch
2 times, most recently
from
July 22, 2021 07:47
50a74e3
to
7a6d85a
Compare
zannkukai
approved these changes
Jul 22, 2021
...cord/detail-view/document-detail-view/document-description/document-description.component.ts
Outdated
Show resolved
Hide resolved
...cord/detail-view/document-detail-view/document-description/document-description.component.ts
Outdated
Show resolved
Hide resolved
...cord/detail-view/document-detail-view/document-description/document-description.component.ts
Outdated
Show resolved
Hide resolved
...cord/detail-view/document-detail-view/document-description/document-description.component.ts
Outdated
Show resolved
Hide resolved
Garfield-fr
force-pushed
the
zub-all-fields
branch
from
July 23, 2021 10:18
7a6d85a
to
005225d
Compare
Garfield-fr
force-pushed
the
zub-all-fields
branch
2 times, most recently
from
July 23, 2021 10:43
26ae9b3
to
583c9c6
Compare
sebdeleze
approved these changes
Jul 26, 2021
...cord/detail-view/document-detail-view/document-description/document-description.component.ts
Show resolved
Hide resolved
benerken
approved these changes
Jul 29, 2021
Garfield-fr
force-pushed
the
zub-all-fields
branch
from
August 4, 2021 09:00
583c9c6
to
9b7b4c8
Compare
Garfield-fr
force-pushed
the
zub-all-fields
branch
3 times, most recently
from
August 10, 2021 14:07
395414f
to
b9cb3bb
Compare
Garfield-fr
force-pushed
the
zub-all-fields
branch
3 times, most recently
from
August 17, 2021 13:11
6571648
to
0ce5162
Compare
Garfield-fr
force-pushed
the
zub-all-fields
branch
4 times, most recently
from
September 16, 2021 05:26
735aad8
to
164858d
Compare
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr
force-pushed
the
zub-all-fields
branch
from
September 16, 2021 05:27
164858d
to
138ea2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
Why are you opening this PR?
How to test?
Code review check list