ci-po: improve settings display in detail view #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
requested review from
BadrAly,
benerken,
blankoworld,
Garfield-fr,
jma,
lauren-d,
sebdeleze and
zannkukai
AoNoOokami
force-pushed
the
zaa-cipo-settings-display
branch
from
9ff3396 to
8d972f1
Compare
Garfield-fr
requested changes
Dec 6, 2019
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Outdated
Show resolved
Hide resolved
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Outdated
Show resolved
Hide resolved
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Outdated
Show resolved
Hide resolved
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Outdated
Show resolved
Hide resolved
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Outdated
Show resolved
Hide resolved
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Outdated
Show resolved
Hide resolved
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Outdated
Show resolved
Hide resolved
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Outdated
Show resolved
Hide resolved
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Outdated
Show resolved
Hide resolved
...in/src/app/record/detail-view/circ-policy-detail-view/circ-policy-detail-view.component.html
Outdated
Show resolved
Hide resolved
* Displays settings within a matrix for a more effective visual aspect. * Removes useless component. Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami
force-pushed
the
zaa-cipo-settings-display
branch
from
8d972f1 to
5a01e55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Why are you opening this PR?
Part of #43
To improve settings display in ci-po detail view as asked during the demo.
How to test?
See detailed views of ci-po.
Check responsiveness, for example with 'no checkout' and 'extended' ci-po.
Code review check list