document: dynamic loading for items informations #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
f: public ui
zannkukai
force-pushed
the
zan-dynmaic-items-loading
branch
from
81278f3
to
f21a2b8
Compare
Garfield-fr
approved these changes
Jul 22, 2021
projects/public-search/src/app/document-detail/holdings/items/items.component.html
Outdated
Show resolved
Hide resolved
When displaying the document detail view, items metadata are loaded for each holdings causing a backend call even if the holding is collapsed. Now, the items metadata are loaded only if user expands the holdings. Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
force-pushed
the
zan-dynmaic-items-loading
branch
from
f21a2b8
to
9df01d9
Compare
sebdeleze
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When displaying the document detail view, items metadata are loaded for
each holdings causing a backend call even if the holding is collapsed.
Now, the items metadata are loaded only if user expand holding;
Co-authored-by: Renaud Michotte renaud.michotte@gmail.com
Code review check list